some notes about loading and container width

This commit is contained in:
Tom 2022-04-08 21:40:11 +02:00
parent 49f4ce7149
commit 45a66ab694

View file

@ -126,6 +126,8 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
const self = this; const self = this;
this.$widget = $(TPL); this.$widget = $(TPL);
// leads to contain: none
// https://developer.mozilla.org/en-US/docs/Web/CSS/contain
this.contentSized(); this.contentSized();
this.$render = this.$widget.find('.canvas-note-render'); this.$render = this.$widget.find('.canvas-note-render');
this.$renderElement = this.$render.get(0); this.$renderElement = this.$render.get(0);
@ -172,6 +174,11 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
const content = JSON.parse(noteComplement.content || ""); const content = JSON.parse(noteComplement.content || "");
const {elements, appState, files} = content; const {elements, appState, files} = content;
/**
* FIXME: appState will overwrite the width and height of container and lead to bugs!
* maybe get width/height here anew?
*/
const sceneData = { const sceneData = {
elements, elements,
appState, appState,
@ -242,7 +249,6 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
this.spacedUpdate.scheduleUpdate(); this.spacedUpdate.scheduleUpdate();
} }
/** /**
* *
// FIXME: also, after we save, a refresh is triggered. if we switch too fast, we might get the saved // FIXME: also, after we save, a refresh is triggered. if we switch too fast, we might get the saved
@ -308,6 +314,9 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
}; };
window.addEventListener("resize", onResize); window.addEventListener("resize", onResize);
// ensure that resize is also called for split creation and deletion
// not really the problem. problem is saved appState!
// self.$renderElement.addEventListener("resize", onResize);
return () => window.removeEventListener("resize", onResize); return () => window.removeEventListener("resize", onResize);
}, [excalidrawWrapperRef]); }, [excalidrawWrapperRef]);
@ -383,4 +392,3 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
this.currentSceneVersion = this.getSceneVersion(); this.currentSceneVersion = this.getSceneVersion();
} }
} }