From 480aec1667df7131c31b0741efe44b9d7c9a58e6 Mon Sep 17 00:00:00 2001
From: zadam <adam.zivner@gmail.com>
Date: Fri, 22 Jan 2021 15:16:08 +0100
Subject: [PATCH] size calculation is always on demand

---
 package-lock.json                             |  6 +--
 package.json                                  |  2 +-
 .../widgets/collapsible_widgets/note_info.js  | 40 +++++++++++++------
 3 files changed, 31 insertions(+), 17 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 26d33a1ac..fcf93bb00 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -2360,9 +2360,9 @@
       }
     },
     "dayjs": {
-      "version": "1.10.3",
-      "resolved": "https://registry.npmjs.org/dayjs/-/dayjs-1.10.3.tgz",
-      "integrity": "sha512-/2fdLN987N8Ki7Id8BUN2nhuiRyxTLumQnSQf9CNncFCyqFsSKb9TNhzRYcC8K8eJSJOKvbvkImo/MKKhNi4iw=="
+      "version": "1.10.4",
+      "resolved": "https://registry.npmjs.org/dayjs/-/dayjs-1.10.4.tgz",
+      "integrity": "sha512-RI/Hh4kqRc1UKLOAf/T5zdMMX5DQIlDxwUe3wSyMMnEbGunnpENCdbUgM+dW7kXidZqCttBrmw7BhN4TMddkCw=="
     },
     "debug": {
       "version": "4.1.1",
diff --git a/package.json b/package.json
index 708014ff0..aed058f80 100644
--- a/package.json
+++ b/package.json
@@ -32,7 +32,7 @@
     "commonmark": "0.29.3",
     "cookie-parser": "1.4.5",
     "csurf": "1.11.0",
-    "dayjs": "1.10.3",
+    "dayjs": "1.10.4",
     "ejs": "3.1.5",
     "electron-debug": "3.2.0",
     "electron-dl": "3.0.2",
diff --git a/src/public/app/widgets/collapsible_widgets/note_info.js b/src/public/app/widgets/collapsible_widgets/note_info.js
index ca2172731..c204590fe 100644
--- a/src/public/app/widgets/collapsible_widgets/note_info.js
+++ b/src/public/app/widgets/collapsible_widgets/note_info.js
@@ -43,9 +43,15 @@ const TPL = `
         <th>Note size:</th>
         
         <td colspan="3">
-            <span class="note-size"></span>
+            <button class="btn btn-sm calculate-button" style="padding: 0px 10px 0px 10px;">
+                <span class="bx bx-calculator"></span> calculate
+            </button>
             
-            (subtree size: <span class="subtree-size"></span>)
+            <span class="note-sizes-wrapper">
+                <span class="note-size"></span>
+                
+                (subtree size: <span class="subtree-size"></span>)
+            </span>
         </td>
     </tr>
 </table>
@@ -66,8 +72,25 @@ export default class NoteInfoWidget extends CollapsibleWidget {
         this.$dateModified = this.$body.find(".note-info-date-modified");
         this.$type = this.$body.find(".note-info-type");
         this.$mime = this.$body.find(".note-info-mime");
+
+        this.$noteSizesWrapper = this.$body.find('.note-sizes-wrapper');
         this.$noteSize = this.$body.find(".note-size");
         this.$subTreeSize = this.$body.find(".subtree-size");
+
+        this.$calculateButton = this.$body.find(".calculate-button");
+        this.$calculateButton.on('click', async () => {
+            this.$noteSizesWrapper.show();
+            this.$calculateButton.hide();
+
+            this.$noteSize.empty().append($('<span class="bx bx-loader bx-spin"></span>'));
+            this.$subTreeSize.empty().append($('<span class="bx bx-loader bx-spin"></span>'));
+
+            const noteSizeResp = await server.get(`stats/note-size/${this.noteId}`);
+            this.$noteSize.text(this.formatSize(noteSizeResp.noteSize));
+
+            const subTreeSizeResp = await server.get(`stats/subtree-size/${this.noteId}`);
+            this.$subTreeSize.text(this.formatSize(subTreeSizeResp.subTreeSize));
+        });
     }
 
     async refreshWithNote(note) {
@@ -91,17 +114,8 @@ export default class NoteInfoWidget extends CollapsibleWidget {
             this.$mime.empty();
         }
 
-        const resp = await server.get(`stats/note-size/${note.noteId}`);
-        this.$noteSize.text(this.formatSize(resp.noteSize));
-
-        const $calculateLink = $('<a href="javascript:">calculate</a>')
-            .on('click', async () => {
-                const resp = await server.get(`stats/subtree-size/${note.noteId}`);
-
-                this.$subTreeSize.text(this.formatSize(resp.subTreeSize));
-            })
-
-        this.$subTreeSize.empty().append($calculateLink);
+        this.$calculateButton.show();
+        this.$noteSizesWrapper.hide();
     }
 
     formatSize(size) {