fix note reordering sync again

This commit is contained in:
azivner 2018-04-12 18:31:29 -04:00
parent 6a57b8a7e7
commit 592c51d1a5
3 changed files with 7 additions and 15 deletions

View file

@ -68,7 +68,7 @@ async function update(req) {
const entities = req.body.entities; const entities = req.body.entities;
for (const {sync, entity} of entities) { for (const {sync, entity} of entities) {
await syncUpdateService.updateEntity(sync.entityName, entity, sourceId); await syncUpdateService.updateEntity(sync, entity, sourceId);
} }
} }

View file

@ -197,16 +197,6 @@ async function runAllChecks() {
AND images.isDeleted = 1`, AND images.isDeleted = 1`,
"Note image is not deleted while image is deleted for noteImageId", errorList); "Note image is not deleted while image is deleted for noteImageId", errorList);
await runCheck(`
SELECT
noteId
FROM
notes
WHERE
isDeleted = 0
AND (title IS NULL OR content IS NULL)`,
"Note has null title or text", errorList);
await runCheck(` await runCheck(`
SELECT SELECT
noteId noteId

View file

@ -3,7 +3,9 @@ const log = require('./log');
const eventLogService = require('./event_log'); const eventLogService = require('./event_log');
const syncTableService = require('./sync_table'); const syncTableService = require('./sync_table');
async function updateEntity(entityName, entity, sourceId) { async function updateEntity(sync, entity, sourceId) {
const {entityName} = sync;
if (entityName === 'notes') { if (entityName === 'notes') {
await updateNote(entity, sourceId); await updateNote(entity, sourceId);
} }
@ -14,7 +16,7 @@ async function updateEntity(entityName, entity, sourceId) {
await updateNoteRevision(entity, sourceId); await updateNoteRevision(entity, sourceId);
} }
else if (entityName === 'note_reordering') { else if (entityName === 'note_reordering') {
await updateNoteReordering(entity, sourceId); await updateNoteReordering(sync.entityId, entity, sourceId);
} }
else if (entityName === 'options') { else if (entityName === 'options') {
await updateOptions(entity, sourceId); await updateOptions(entity, sourceId);
@ -94,13 +96,13 @@ async function updateNoteRevision(entity, sourceId) {
}); });
} }
async function updateNoteReordering(entity, sourceId) { async function updateNoteReordering(entityId, entity, sourceId) {
await sql.transactional(async () => { await sql.transactional(async () => {
Object.keys(entity).forEach(async key => { Object.keys(entity).forEach(async key => {
await sql.execute("UPDATE branches SET notePosition = ? WHERE branchId = ?", [entity[key], key]); await sql.execute("UPDATE branches SET notePosition = ? WHERE branchId = ?", [entity[key], key]);
}); });
await syncTableService.addNoteReorderingSync(entity.parentNoteId, sourceId); await syncTableService.addNoteReorderingSync(entityId, sourceId);
}); });
} }