From 6cae68288d9f7495b51d25f33c6bd16c10f03ea6 Mon Sep 17 00:00:00 2001
From: Tom <7283497+thfrei@users.noreply.github.com>
Date: Mon, 9 May 2022 15:15:07 +0200
Subject: [PATCH] adhere to convention, prefixing jquery objects with $ and dom
 not

---
 src/public/app/dialogs/note_revisions.js           | 4 ++--
 src/public/app/widgets/type_widgets/canvas_note.js | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/public/app/dialogs/note_revisions.js b/src/public/app/dialogs/note_revisions.js
index 647b760ac..c0333b525 100644
--- a/src/public/app/dialogs/note_revisions.js
+++ b/src/public/app/dialogs/note_revisions.js
@@ -187,8 +187,8 @@ async function setContentPane() {
              * maxWidth: 100% use full width of container but do not enlarge!
              * height:auto to ensure that height scales with width
              */
-            const svgHtml = $(svg).css({maxWidth: "100%", height: "auto"});
-            $content.html($('<div>').append(svgHtml));
+            const $svgHtml = $(svg).css({maxWidth: "100%", height: "auto"});
+            $content.html($('<div>').append($svgHtml));
         } catch(err) {
             console.error("error parsing fullNoteRevision.content as JSON", fullNoteRevision.content, err);
             $content.html($("<div>").text("Error parsing content. Please check console.error() for more details."));
diff --git a/src/public/app/widgets/type_widgets/canvas_note.js b/src/public/app/widgets/type_widgets/canvas_note.js
index fa8cb1b37..f56f98ceb 100644
--- a/src/public/app/widgets/type_widgets/canvas_note.js
+++ b/src/public/app/widgets/type_widgets/canvas_note.js
@@ -70,7 +70,7 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
         // will be overwritten
         this.excalidrawRef;
         this.$render;
-        this.$renderElement;
+        this.renderElement;
         this.$widget;
         this.reactHandlers; // used to control react state
         
@@ -114,7 +114,7 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
         // this.contentSized();
         this.$widget.toggleClass("full-height", true); // only add
         this.$render = this.$widget.find('.canvas-note-render');
-        this.$renderElement = this.$render.get(0);
+        this.renderElement = this.$render.get(0);
         // this.log("doRender", this.$widget);
 
         libraryLoader
@@ -125,8 +125,8 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
                 const React = window.React;
                 const ReactDOM = window.ReactDOM;
                 
-                ReactDOM.unmountComponentAtNode(this.$renderElement);
-                ReactDOM.render(React.createElement(this.ExcalidrawReactApp), this.$renderElement);
+                ReactDOM.unmountComponentAtNode(this.renderElement);
+                ReactDOM.render(React.createElement(this.ExcalidrawReactApp), this.renderElement);
             })
 
         return this.$widget;