From 6d51593b7d09f5ea115d2675d77a0333916b7155 Mon Sep 17 00:00:00 2001 From: zadam Date: Sat, 5 Jun 2021 22:07:15 +0200 Subject: [PATCH] removed CSS contain from widgets --- src/public/app/layouts/desktop_layout.js | 4 +--- src/public/app/layouts/mobile_layout.js | 2 +- src/public/app/services/resizer.js | 2 +- .../app/widgets/attribute_widgets/attribute_detail.js | 1 - .../app/widgets/attribute_widgets/attribute_editor.js | 1 - src/public/app/widgets/basic_widget.js | 6 ++++-- src/public/app/widgets/buttons/button_widget.js | 1 - src/public/app/widgets/buttons/global_menu.js | 1 - src/public/app/widgets/buttons/note_actions.js | 1 - src/public/app/widgets/collapsible_widget.js | 1 - src/public/app/widgets/containers/ribbon_container.js | 1 - src/public/app/widgets/history_navigation.js | 1 - .../app/widgets/mobile_widgets/close_detail_button.js | 1 - src/public/app/widgets/mobile_widgets/mobile_detail_menu.js | 1 - .../app/widgets/mobile_widgets/mobile_global_buttons.js | 1 - src/public/app/widgets/note_detail.js | 1 - src/public/app/widgets/note_icon.js | 1 - src/public/app/widgets/note_list.js | 1 - src/public/app/widgets/note_title.js | 1 - src/public/app/widgets/note_type.js | 1 - src/public/app/widgets/note_update_status.js | 1 - src/public/app/widgets/protected_note_switch.js | 1 - src/public/app/widgets/quick_search.js | 1 - src/public/app/widgets/ribbon_widgets/basic_properties.js | 1 - src/public/app/widgets/ribbon_widgets/book_properties.js | 1 - src/public/app/widgets/ribbon_widgets/file_properties.js | 1 - src/public/app/widgets/ribbon_widgets/image_properties.js | 1 - .../app/widgets/ribbon_widgets/inherited_attribute_list.js | 1 - src/public/app/widgets/ribbon_widgets/link_map.js | 1 - src/public/app/widgets/ribbon_widgets/note_info_widget.js | 1 - src/public/app/widgets/ribbon_widgets/note_paths.js | 1 - src/public/app/widgets/ribbon_widgets/note_properties.js | 1 - .../app/widgets/ribbon_widgets/owned_attribute_list.js | 1 - .../app/widgets/ribbon_widgets/promoted_attributes.js | 1 - src/public/app/widgets/ribbon_widgets/search_definition.js | 2 -- src/public/app/widgets/ribbon_widgets/similar_notes.js | 1 - src/public/app/widgets/search_result.js | 1 - src/public/app/widgets/sql_result.js | 1 - src/public/app/widgets/sql_table_schemas.js | 1 - src/public/app/widgets/sync_status.js | 1 - src/public/app/widgets/tab_row.js | 1 - src/public/app/widgets/title_bar_buttons.js | 1 - src/public/app/widgets/type_widgets/book.js | 1 - src/public/app/widgets/type_widgets/deleted.js | 1 - src/public/app/widgets/type_widgets/editable_code.js | 1 - src/public/app/widgets/type_widgets/editable_text.js | 1 - src/public/app/widgets/type_widgets/empty.js | 1 - src/public/app/widgets/type_widgets/file.js | 1 - src/public/app/widgets/type_widgets/image.js | 1 - src/public/app/widgets/type_widgets/protected_session.js | 1 - src/public/app/widgets/type_widgets/read_only_code.js | 1 - src/public/app/widgets/type_widgets/read_only_text.js | 1 - src/public/app/widgets/type_widgets/relation_map.js | 1 - src/public/app/widgets/type_widgets/render.js | 1 - src/public/stylesheets/style.css | 4 ---- 55 files changed, 7 insertions(+), 62 deletions(-) diff --git a/src/public/app/layouts/desktop_layout.js b/src/public/app/layouts/desktop_layout.js index ef22157f1..39ad7b027 100644 --- a/src/public/app/layouts/desktop_layout.js +++ b/src/public/app/layouts/desktop_layout.js @@ -71,7 +71,6 @@ export default class DesktopLayout { .command("showRecentChanges")) .child(new SpacerWidget(40, 0)) .child(new FlexContainer("column") - .overflowing() .id("plugin-buttons")) .child(new SpacerWidget(0, 1000)) .child(new ProtectedSessionStatusWidget()) @@ -87,7 +86,7 @@ export default class DesktopLayout { .child(new FlexContainer('column') .id('rest-pane') .css("flex-grow", "1") - .child(new FlexContainer('row').overflowing() + .child(new FlexContainer('row') .child(new TabRowWidget()) .child(new TitleBarButtonsWidget()) .css('height', '40px') @@ -103,7 +102,6 @@ export default class DesktopLayout { .child(new FlexContainer('row').class('title-row') .css('align-items: center;') .cssBlock('.title-row > * { margin: 5px; }') - .overflowing() .child(new NoteIconWidget()) .child(new NoteTitleWidget()) .child(new SpacerWidget(0, 1)) diff --git a/src/public/app/layouts/mobile_layout.js b/src/public/app/layouts/mobile_layout.js index a715b5563..6ca7ac95b 100644 --- a/src/public/app/layouts/mobile_layout.js +++ b/src/public/app/layouts/mobile_layout.js @@ -98,7 +98,7 @@ export default class MobileLayout { .child(new ScreenContainer("detail", "column") .class("d-sm-flex d-md-flex d-lg-flex d-xl-flex col-12 col-sm-7 col-md-8 col-lg-8") .css('max-height', '100%') - .child(new FlexContainer('row').overflowing() + .child(new FlexContainer('row') .css('font-size', 'larger') .css('align-items', 'center') .css('position', 'fixed') diff --git a/src/public/app/services/resizer.js b/src/public/app/services/resizer.js index f613fca04..0901a05c2 100644 --- a/src/public/app/services/resizer.js +++ b/src/public/app/services/resizer.js @@ -54,7 +54,7 @@ function setupRightPaneResizer() { leftInstance = Split(['#center-pane', '#right-pane'], { sizes: [100 - rightPaneWidth, rightPaneWidth], gutterSize: 5, - onDragEnd: sizes => options.save('rightPaneWidth', Math.round(sizes[0])) + onDragEnd: sizes => options.save('rightPaneWidth', Math.round(sizes[1])) }); } } diff --git a/src/public/app/widgets/attribute_widgets/attribute_detail.js b/src/public/app/widgets/attribute_widgets/attribute_detail.js index 5d9e2f481..1860f4361 100644 --- a/src/public/app/widgets/attribute_widgets/attribute_detail.js +++ b/src/public/app/widgets/attribute_widgets/attribute_detail.js @@ -237,7 +237,6 @@ export default class AttributeDetailWidget extends NoteContextAwareWidget { utils.bindElShortcut(this.$widget, 'ctrl+return', () => this.saveAndClose()); utils.bindElShortcut(this.$widget, 'esc', () => this.cancelAndClose()); - this.contentSized(); this.$title = this.$widget.find('.attr-detail-title'); diff --git a/src/public/app/widgets/attribute_widgets/attribute_editor.js b/src/public/app/widgets/attribute_widgets/attribute_editor.js index 8f0c69a20..ff148013c 100644 --- a/src/public/app/widgets/attribute_widgets/attribute_editor.js +++ b/src/public/app/widgets/attribute_widgets/attribute_editor.js @@ -185,7 +185,6 @@ export default class AttributeEditorWidget extends NoteContextAwareWidget { doRender() { this.$widget = $(TPL); - this.contentSized(); this.$editor = this.$widget.find('.attribute-list-editor'); this.initialized = this.initEditor(); diff --git a/src/public/app/widgets/basic_widget.js b/src/public/app/widgets/basic_widget.js index bf3052cdf..be723e8be 100644 --- a/src/public/app/widgets/basic_widget.js +++ b/src/public/app/widgets/basic_widget.js @@ -26,12 +26,14 @@ class BasicWidget extends Component { } contentSized() { - this.css('contain', 'layout paint'); + console.log("Using contentSized() is deprecated NOOP and it is recommended to remove its use."); + return this; } overflowing() { - this.css('contain', 'none !important'); + console.log("Using overflowing() is deprecated NOOP and it is recommended to remove its use."); + return this; } diff --git a/src/public/app/widgets/buttons/button_widget.js b/src/public/app/widgets/buttons/button_widget.js index fdf0832b0..663235531 100644 --- a/src/public/app/widgets/buttons/button_widget.js +++ b/src/public/app/widgets/buttons/button_widget.js @@ -19,7 +19,6 @@ export default class ButtonWidget extends NoteContextAwareWidget { doRender() { this.$widget = $(TPL); - this.overflowing(); if (this.settings.onClick) { this.$widget.on("click", () => this.settings.onClick(this)); diff --git a/src/public/app/widgets/buttons/global_menu.js b/src/public/app/widgets/buttons/global_menu.js index f35800f56..3f1a2a60e 100644 --- a/src/public/app/widgets/buttons/global_menu.js +++ b/src/public/app/widgets/buttons/global_menu.js @@ -76,7 +76,6 @@ const TPL = ` export default class GlobalMenuWidget extends BasicWidget { doRender() { this.$widget = $(TPL); - this.overflowing(); this.$widget.find(".show-about-dialog-button").on('click', () => import("../../dialogs/about.js").then(d => d.showDialog())); diff --git a/src/public/app/widgets/buttons/note_actions.js b/src/public/app/widgets/buttons/note_actions.js index 74767d761..51cf5006f 100644 --- a/src/public/app/widgets/buttons/note_actions.js +++ b/src/public/app/widgets/buttons/note_actions.js @@ -32,7 +32,6 @@ const TPL = ` export default class NoteActionsWidget extends NoteContextAwareWidget { doRender() { this.$widget = $(TPL); - this.overflowing(); this.$showSourceButton = this.$widget.find('.show-source-button'); this.$renderNoteButton = this.$widget.find('.render-note-button'); diff --git a/src/public/app/widgets/collapsible_widget.js b/src/public/app/widgets/collapsible_widget.js index e5563fb7f..7533fe429 100644 --- a/src/public/app/widgets/collapsible_widget.js +++ b/src/public/app/widgets/collapsible_widget.js @@ -16,7 +16,6 @@ export default class CollapsibleWidget extends NoteContextAwareWidget { doRender() { this.$widget = $(WIDGET_TPL); - this.contentSized(); this.$widget.find('[data-target]').attr('data-target', "#" + this.componentId); this.$bodyWrapper = this.$widget.find('.body-wrapper'); diff --git a/src/public/app/widgets/containers/ribbon_container.js b/src/public/app/widgets/containers/ribbon_container.js index 1d26a3c9f..a18f335d9 100644 --- a/src/public/app/widgets/containers/ribbon_container.js +++ b/src/public/app/widgets/containers/ribbon_container.js @@ -130,7 +130,6 @@ export default class RibbonContainer extends NoteContextAwareWidget { doRender() { this.$widget = $(TPL); - this.overflowing(); this.$tabContainer = this.$widget.find('.ribbon-tab-container'); this.$buttonContainer = this.$widget.find('.ribbon-button-container'); diff --git a/src/public/app/widgets/history_navigation.js b/src/public/app/widgets/history_navigation.js index fb39b811b..09ab85984 100644 --- a/src/public/app/widgets/history_navigation.js +++ b/src/public/app/widgets/history_navigation.js @@ -25,7 +25,6 @@ export default class HistoryNavigationWidget extends BasicWidget { } this.$widget = $(TPL); - this.contentSized(); const contextMenuHandler = e => { e.preventDefault(); diff --git a/src/public/app/widgets/mobile_widgets/close_detail_button.js b/src/public/app/widgets/mobile_widgets/close_detail_button.js index af4ab4c4a..d05aec633 100644 --- a/src/public/app/widgets/mobile_widgets/close_detail_button.js +++ b/src/public/app/widgets/mobile_widgets/close_detail_button.js @@ -8,7 +8,6 @@ const TPL = ` class CloseDetailButtonWidget extends BasicWidget { doRender() { this.$widget = $(TPL); - this.overflowing(); this.$widget.on('click', () => this.triggerCommand('setActiveScreen', {screen:'tree'})); } diff --git a/src/public/app/widgets/mobile_widgets/mobile_detail_menu.js b/src/public/app/widgets/mobile_widgets/mobile_detail_menu.js index be20afe75..8d01c322a 100644 --- a/src/public/app/widgets/mobile_widgets/mobile_detail_menu.js +++ b/src/public/app/widgets/mobile_widgets/mobile_detail_menu.js @@ -10,7 +10,6 @@ const TPL = `