From 9404e27cbacf8a044d3af009b4a1ef6d75240869 Mon Sep 17 00:00:00 2001
From: zadam <zadam.apps@gmail.com>
Date: Tue, 3 Sep 2019 21:16:14 +0200
Subject: [PATCH] similar notes is async'd a bit to not block the event loop
 too much

---
 src/services/note_cache.js | 34 +++++++++++++++++++++++++++-------
 1 file changed, 27 insertions(+), 7 deletions(-)

diff --git a/src/services/note_cache.js b/src/services/note_cache.js
index 3c628e0b8..5368fb09e 100644
--- a/src/services/note_cache.js
+++ b/src/services/note_cache.js
@@ -364,17 +364,37 @@ function evaluateSimilarity(text1, text2, noteId, results) {
     }
 }
 
-function findSimilarNotes(title) {
+/**
+ * Point of this is to break up long running sync process to avoid blocking
+ * see https://snyk.io/blog/nodejs-how-even-quick-async-functions-can-block-the-event-loop-starve-io/
+ */
+function setImmediatePromise() {
+    return new Promise((resolve) => {
+        setImmediate(() => resolve());
+    });
+}
+
+async function evaluateSimilarityDict(title, dict, results) {
+    let i = 0;
+
+    for (const noteId in dict) {
+        evaluateSimilarity(title, dict[noteId], noteId, results);
+
+        i++;
+
+        if (i % 200 === 0) {
+            await setImmediatePromise();
+        }
+    }
+}
+
+async function findSimilarNotes(title) {
     const results = [];
 
-    for (const noteId in noteTitles) {
-        evaluateSimilarity(title, noteTitles[noteId], noteId, results);
-    }
+    await evaluateSimilarityDict(title, noteTitles, results);
 
     if (protectedSessionService.isProtectedSessionAvailable()) {
-        for (const noteId in protectedNoteTitles) {
-            evaluateSimilarity(title, protectedNoteTitles[noteId], noteId, results);
-        }
+        await evaluateSimilarityDict(title, protectedNoteTitles, results);
     }
 
     results.sort((a, b) => a.coeff > b.coeff ? -1 : 1);