From a8e45019e43df54d97e700e0edf896292966500b Mon Sep 17 00:00:00 2001 From: azivner Date: Sat, 30 Dec 2017 20:14:05 -0500 Subject: [PATCH] failing early when decryption fails --- services/data_encryption.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/services/data_encryption.js b/services/data_encryption.js index 31ebf9044..4de137972 100644 --- a/services/data_encryption.js +++ b/services/data_encryption.js @@ -1,6 +1,7 @@ "use strict"; const crypto = require('crypto'); +const log = require('./log'); function arraysIdentical(a, b) { let i = a.length; @@ -72,7 +73,15 @@ function decrypt(key, iv, cipherText) { function decryptString(dataKey, iv, cipherText) { const buffer = decrypt(dataKey, iv, cipherText); - return buffer.toString('utf-8'); + const str = buffer.toString('utf-8'); + + if (str === 'false') { + log.error("Could not decrypt string. Buffer: " + buffer); + + throw new Error("Could not decrypt string."); + } + + return str; } function noteTitleIv(iv) {