From af654a171f4e528e4c77075a12b71ea814904c8e Mon Sep 17 00:00:00 2001
From: zadam <zadam.apps@gmail.com>
Date: Thu, 22 Dec 2022 18:53:04 +0100
Subject: [PATCH] execute all DB migrations in one transaction

---
 src/services/migration.js | 62 ++++++++++++++++++++-------------------
 1 file changed, 32 insertions(+), 30 deletions(-)

diff --git a/src/services/migration.js b/src/services/migration.js
index adcd4981c..a5ac2be4f 100644
--- a/src/services/migration.js
+++ b/src/services/migration.js
@@ -6,25 +6,6 @@ const utils = require('./utils');
 const resourceDir = require('./resource_dir');
 const appInfo = require('./app_info');
 
-function executeMigration(mig) {
-    sql.transactional(() => {
-        if (mig.type === 'sql') {
-            const migrationSql = fs.readFileSync(`${resourceDir.MIGRATIONS_DIR}/${mig.file}`).toString('utf8');
-
-            console.log(`Migration with SQL script: ${migrationSql}`);
-
-            sql.executeScript(migrationSql);
-        } else if (mig.type === 'js') {
-            console.log("Migration with JS module");
-
-            const migrationModule = require(`${resourceDir.MIGRATIONS_DIR}/${mig.file}`);
-            migrationModule();
-        } else {
-            throw new Error(`Unknown migration type ${mig.type}`);
-        }
-    });
-}
-
 async function migrate() {
     const migrations = [];
 
@@ -64,22 +45,43 @@ async function migrate() {
 
     migrations.sort((a, b) => a.dbVersion - b.dbVersion);
 
-    for (const mig of migrations) {
-        try {
-            log.info(`Attempting migration to version ${mig.dbVersion}`);
+    // all migrations are executed in one transaction - upgrade either succeeds or the user can stay at the old version
+    sql.transactional(() => {
+        for (const mig of migrations) {
+            try {
+                log.info(`Attempting migration to version ${mig.dbVersion}`);
 
-            executeMigration(mig);
+                executeMigration(mig);
 
-            sql.execute(`UPDATE options SET value = ? WHERE name = ?`, [mig.dbVersion.toString(), "dbVersion"]);
+                sql.execute(`UPDATE options
+                             SET value = ?
+                             WHERE name = ?`, [mig.dbVersion.toString(), "dbVersion"]);
 
-            log.info(`Migration to version ${mig.dbVersion} has been successful.`);
+                log.info(`Migration to version ${mig.dbVersion} has been successful.`);
+            } catch (e) {
+                log.error(`error during migration to version ${mig.dbVersion}: ${e.stack}`);
+                log.error("migration failed, crashing hard"); // this is not very user friendly :-/
+
+                utils.crash();
+            }
         }
-        catch (e) {
-            log.error(`error during migration to version ${mig.dbVersion}: ${e.stack}`);
-            log.error("migration failed, crashing hard"); // this is not very user friendly :-/
+    });
+}
 
-            utils.crash();
-        }
+function executeMigration(mig) {
+    if (mig.type === 'sql') {
+        const migrationSql = fs.readFileSync(`${resourceDir.MIGRATIONS_DIR}/${mig.file}`).toString('utf8');
+
+        console.log(`Migration with SQL script: ${migrationSql}`);
+
+        sql.executeScript(migrationSql);
+    } else if (mig.type === 'js') {
+        console.log("Migration with JS module");
+
+        const migrationModule = require(`${resourceDir.MIGRATIONS_DIR}/${mig.file}`);
+        migrationModule();
+    } else {
+        throw new Error(`Unknown migration type ${mig.type}`);
     }
 }