Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-01-19 22:50:13 +08:00
Code Issues Projects Releases Packages Wiki Activity

Added the leading 'www' to the social links in the sidebar, now curso… (#1559)

Browse source 
* Added the leading 'www' to the facebook and linkedin links in the sidebar, now cursor pointer is shown wheh hovering social links in the sidebar

* SocialProfileLink now accepts a hostname parameter used to generate social link urls, service remains only for the img
This commit is contained in:
Alessandro Magionami 2019-09-23 17:39:01 +02:00 committed by Ben Gotow
parent de07989480
commit 63db2fbf15
2 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
app/internal_packages/participant-profile/lib/sidebar-participant-profile.tsx
View file

@ -104,14 +104,15 @@ class ProfilePictureOrColorBox extends React.Component<{
);
}
}
class SocialProfileLink extends React.Component<{ handle: string; service: string }> {
class SocialProfileLink extends React.Component<{ handle: string; service: string, hostname: string }> {
static propTypes = {
service: PropTypes.string,
handle: PropTypes.string,
hostname: PropTypes.string,
};
render() {
const { handle, service } = this.props;
const { handle, service, hostname } = this.props;
if (!handle) {
return false;
@ -119,8 +120,8 @@ class SocialProfileLink extends React.Component<{ handle: string; service: strin
return (
<a
className="social-profile-item"
title={`https://${service}.com/${handle}`}
href={`https://${service}.com/${handle}`}
title={`https://${hostname}/${handle}`}
href={`https://${hostname}/${handle}`}
>
<RetinaImg
url={`mailspring://participant-profile/assets/${service}-sidebar-icon@2x.png`}
@ -473,10 +474,10 @@ export default class SidebarParticipantProfile extends React.Component<
<IconRow icon="funding" node={funding} />
<div className="social-profiles-wrap">
<SocialProfileLink service="facebook" handle={facebook && facebook.handle} />
<SocialProfileLink service="crunchbase" handle={crunchbase && crunchbase.handle} />
<SocialProfileLink service="linkedin" handle={linkedin && linkedin.handle} />
<SocialProfileLink service="twitter" handle={twitter && twitter.handle} />
<SocialProfileLink service="facebook" hostname="www.facebook.com" handle={facebook && facebook.handle} />
<SocialProfileLink service="crunchbase" hostname="www.crunchbase.com" handle={crunchbase && crunchbase.handle} />
<SocialProfileLink service="linkedin" hostname="www.linkedin.com" handle={linkedin && linkedin.handle} />
<SocialProfileLink service="twitter" hostname="twitter.com" handle={twitter && twitter.handle} />
</div>
</div>
</div>
@ -513,9 +514,9 @@ export default class SidebarParticipantProfile extends React.Component<
</div>
<div className="social-profiles-wrap">
<SocialProfileLink service="facebook" handle={facebook && facebook.handle} />
<SocialProfileLink service="linkedin" handle={linkedin && `in/${linkedin.handle}`} />
<SocialProfileLink service="twitter" handle={twitter && twitter.handle} />
<SocialProfileLink service="facebook" hostname="www.facebook.com" handle={facebook && facebook.handle} />
<SocialProfileLink service="linkedin" hostname="www.linkedin.com" handle={linkedin && `in/${linkedin.handle}`} />
<SocialProfileLink service="twitter" hostname="twitter.com" handle={twitter && twitter.handle} />
</div>
</div>

1
app/internal_packages/participant-profile/styles/participant-profile.less
View file

@ -117,6 +117,7 @@
}
.social-profile-item {
margin: 0 10px;
cursor: pointer;
&:first-child {
margin-left: 0;
}