[local-sync] Prefer promises over success option for api requests

Summary: Companion D3869

Test Plan: manual

Reviewers: halla, spang, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D3868

packages/local-sync/src/local-sync-worker/sync-metrics-reporter.js

@@ -38,16 +38,16 @@ class SyncMetricsReporter {
         path: `/ingest-metrics`,
         method: 'POST',
         body: info,
-        error: () => {
-          logger.warn("Metrics Collector: Submission Failed.", info);
-        },
         accountId: AccountStore.accountForEmail(info.emailAddress).id,
-        success: () => {
-          logger.log(info, "Metrics Collector: Submitted.", info);
-        },
       },
     });
-    req.run();
+    req.run()
+    .then(() => {
+      logger.log(info, "Metrics Collector: Submitted.", info);
+    })
+    .catch(() => {
+      logger.warn("Metrics Collector: Submission Failed.", info);
+    })
   }
 }