Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-22 16:26:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

[iso-core] Upgrade nodemailer

Browse source 
Summary:
We were using a version that was ~9 months old and a lot of development has
happened since.

v3 is not compatible w/v2, but it looks like we aren't using any of the
features that had breaking changes:

    http://nodemailer.com/about/migrate/

I chose not to switch to the new built-in OAuth2 token refresh support
because we already have a mechanism for refreshing oauth tokens and
adding a different implementation specifically for SMTP would introduce
more opportunities for bugs.

Since mailcomposer is no longer a dependency of nodemailer, I added this
dependency as well.

Test Plan: manual - sent a message, sent a message w/an attachment

Reviewers: evan, khamidou, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D4201
This commit is contained in:
Christine Spang 2017-03-11 13:44:13 -08:00
parent c8e31a7812
commit e798e50d1a
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/isomorphic-core/package.json
View file

@ -14,7 +14,8 @@
"jasmine": "2.x.x",
"joi": "8.4.2",
"libhoney": "1.0.0-beta.2",
"nodemailer": "2.5.0",
"nodemailer": "3.1.5",
"mailcomposer": "4.0.1",
"promise-props": "1.0.0",
"promise.prototype.finally": "1.0.1",
"rx-lite": "4.0.8",