Ben Gotow
734a52aa6a
fix(config): Move account tokens to system keychain
...
Summary:
This diff also adds an account version number to the config so that the AccountStore can tell whether it should reload accounts (depending on whether it was the instance making tthe changes.)
This diff also fixes a tiny issue where un-opened composers threw an exception if you changed accounts.
Test Plan: New tests
Reviewers: evan, drew, juan
Reviewed By: juan
Subscribers: juan
Differential Revision: https://phab.nylas.com/D2726
2016-03-14 15:14:08 -07:00
Ben Gotow
dbf3610c88
hide(zoom): Remove UI for zoom, move to CONFIG.md
2016-03-14 13:13:32 -07:00
Ben Gotow
465831175a
rm(autolinker): Use our own very simple autolinker
...
Summary:
Autolinker is a great open source project but it attempts to parse HTML with regexp, is quite slow, and hangs on specific emails https://github.com/nylas/N1/issues/1540
This is super bad, and also super unnecessary. I think this should do the trick.
Note: I changed the urlRegex in our Utils to be much more liberal. It now matches anything that looks like a URL, not just things with the http:// and https:// prefixes. It's used in the LinkEditor and onboarding screen (detecting auth errors with urls) and I think it should be ok?
Test Plan: Need to write some tests
Reviewers: evan, juan
Reviewed By: juan
Differential Revision: https://phab.nylas.com/D2725
2016-03-14 12:30:54 -07:00
Juan Tejada
06d7c05aa8
fix(acct-menu): Add option to add account from context menu
2016-03-14 11:22:52 -07:00
Juan Tejada
346dd80a32
fix(specs)
2016-03-14 11:22:42 -07:00
Juan Tejada
c185c0d0e4
fix(mail-labels): Don't display sent
label
...
Reference #1671
2016-03-14 11:04:45 -07:00
Ben Gotow
fc59d88337
fix(spellcheck): Enables spellcheck menu for basic inputs ( #1600 )
...
Summary: Just moves some code so we can easily attach spelling menus to the basic inputs.
Test Plan: Updated existing tests
Reviewers: juan, drew
Reviewed By: drew
Differential Revision: https://phab.nylas.com/D2721
2016-03-14 10:23:57 -07:00
Ben Gotow
a3483c0a2b
Merge pull request #1648 from Eldorado234/patch-2
...
Fixed text overflow in phishing detection indicator
2016-03-14 10:09:21 -07:00
Michael Grinich
1b4739335f
use bullets instead of checkboxes
2016-03-13 18:03:36 -07:00
Michael Grinich
fa7f0faa1b
add hiring note
2016-03-13 17:03:33 -07:00
Jackie Luo
9cc235dbbb
🎨 (themes): Fixes Windows button UI issues in #1649
2016-03-12 11:43:49 -08:00
Jackie Luo
85388c9cb5
Merge pull request #1632 from DavidChouinard/extraneous-scrollbar-fix
...
Fixes scrollbar display when content is not scrollable
2016-03-11 17:31:19 -08:00
Jackie Luo
270d1210b3
fix(themes): Add classes for toolbar elements
2016-03-11 16:55:28 -08:00
Evan Morikawa
ae4ca59526
fix(sidebar): keep trying on 202s
...
Also fixed a bug where the email could come back with different
capitalization causing a cache miss
2016-03-11 16:27:04 -05:00
Evan Morikawa
2d8e65ead4
fix(sidebar): add info@ to blacklist
2016-03-11 16:01:29 -05:00
Jackie Luo
eea5b7b531
update(readme): Streamline plugin lists
2016-03-11 11:43:52 -08:00
Ben Gotow
a61d7b9b3b
fix(message-extension): Exception in base class
2016-03-11 11:35:49 -08:00
Ben Gotow
aaa5bd17b7
fix(menus): Nylas => Nylas N1
2016-03-11 11:35:49 -08:00
Simon Seyer
257f9a13d9
Fixed text overflow in phishing detection indicator
2016-03-11 20:33:06 +01:00
Jackie Luo
5dc07fb739
update(readme): Add bundled versus community packages
2016-03-11 11:26:49 -08:00
Jackie Luo
2c723725b6
fix(themes): Add quick fixes for Ubuntu
2016-03-11 11:02:02 -08:00
Jackie Luo
4bddd302e1
Merge pull request #1629 from ahmedlhanafy/master
...
Added Ubuntu theme to the internal packages
2016-03-11 10:59:30 -08:00
Ben Gotow
714b55b299
Merge pull request #1645 from Eldorado234/patch-1
...
(darkside) Fixed alignment of message headers
2016-03-11 10:24:26 -08:00
Simon Seyer
9cb8a24de8
Fixed alignment of message headers
...
like the phishing indicator.
Before this change: http://pasteboard.co/2bUg8PU9.png
After: http://pasteboard.co/2bUj2Bmz.png
2016-03-11 19:07:52 +01:00
Ben Gotow
d57ef5a060
bump(version): 0.4.14 and changelog
2016-03-10 19:09:00 -08:00
Drew Regitsky
fe11a425cd
fix(templates): fix a null check bug in template contentedtable ext
2016-03-10 19:06:15 -08:00
Juan Tejada
50296ab2d6
fix(mail-rules): Prevent from adding locked categories
2016-03-10 19:01:34 -08:00
Drew Regitsky
9dc53ee1bd
fix(regexp-utils): Also update the regex101 link with test cases
2016-03-10 18:43:02 -08:00
Drew Regitsky
3f017892e0
fix(regexp-utils): Fix urlLinkTagRegex bug
...
Regex was missing a `?`, so consumed all <a> tags on a single line. Fixed
to be non-greedy.
2016-03-10 18:41:01 -08:00
David Chouinard
b20bd9631d
Ensure scroll bar state is updated on content change
2016-03-10 18:37:45 -08:00
David Chouinard
d23f8cfdac
Don't show scrollbars if content is not scrollable
2016-03-10 17:59:06 -08:00
Ahmed Magdy
595bd70514
Added Ubuntu theme to the internal packages
2016-03-11 03:50:19 +02:00
Juan Tejada
42e5f4c605
fix(snooze): Fix getter for inbox category in when moving to snooze
2016-03-10 17:46:23 -08:00
Ben Gotow
1c9da2d586
fix(plugin-auth): POST returns 200, no response body
2016-03-10 17:34:26 -08:00
Juan Tejada
d568d66891
fix(lint): Fix in MailLabelSet
2016-03-10 17:27:51 -08:00
Ben Gotow
0533cf3cb3
fix(labels): Do not re-use mail labels if they're removable
2016-03-10 17:08:42 -08:00
Jackie Luo
1e61f2916b
🎨 (theme-picker): Order internal themes and update theme names
2016-03-10 16:37:06 -08:00
Juan Tejada
c98b394c25
fix(change-labels-task): Update label sets after modelifying
2016-03-10 16:26:25 -08:00
Ben Gotow
21e19cab50
fix(bodies): Message with empty string body showed loading forever
2016-03-10 16:13:17 -08:00
Ben Gotow
a24f67398e
fix(sync): Do not paginate /metadata unless pluginsSupported
2016-03-10 16:03:36 -08:00
Evan Morikawa
963d1d92cb
fix(sidebar): return valid person to prevent cache miss
2016-03-10 18:49:00 -05:00
Juan Tejada
23c68df4c0
fix(sent): Do not allow sent or drafts to be modified
...
- Specifically, when dragging from the sent perspective, we should not
allow the sent label to be removed.
- If moved to trash or spam, `all mail` will be correctly removed from
the thread, but it will keep sent label
- Show sent MailLabel on the threads
2016-03-10 15:44:53 -08:00
Evan Morikawa
b9810d5983
fix(sidebar): change optional bit in package
2016-03-10 18:40:26 -05:00
Evan Morikawa
8f94012dd7
fix(sidebar): don't show nulled profiles
2016-03-10 18:32:37 -05:00
Ben Gotow
716533b9f1
fix(messages): Replace calc
with margin to make plugin styling easier
2016-03-10 15:31:05 -08:00
Ben Gotow
554bb69ad6
fix(labels): Labels should not show "X" in wide mode
2016-03-10 15:31:05 -08:00
Jackie Luo
3630a1425f
🎨 (theme-picker): Adjust styles
2016-03-10 15:18:57 -08:00
Evan Morikawa
93cdbf1d6e
fix(sidebar): explicitly detect 202 and cache null people
2016-03-10 18:16:32 -05:00
Ben Gotow
ba66a91eca
fix(github): Correct minor issue during ES6 conversion
2016-03-10 14:31:50 -08:00
Ben Gotow
85ab3cf0ac
fix(remove-from-view): Missing invocation for non-Gmail
2016-03-10 14:25:28 -08:00