In `fromJSON()`, we were setting `categoriesType` to 'labels' if
the json had a truthy `labels` value. But an emtpy array is truthy,
and K2 always sends an array. This commit changes the conditional
to also ensure the array length is > 0.
Summary:
This commit introduces interruptible sync operations. Now, the `SyncWorker`, `FetchFolderList` operation and `FetchMessagesInFolder` operation can be interrupted at several p
To achieve this, this commit adds an Interruptible abstraction, which is an object that can run functions and interrupt them at points marked by the function. For more info o
This commit also splits up the SyncWorker a little bit to make it smaller, byadding a SyncbackTaskWorker.
Test Plan: manual
Reviewers: evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D3613
Summary:
When the error details are too long, the error dialog went off screen and
could not be closed. The native dialog doesn't have any scroll support and
you can only pass it plain text, so this diff moves the error details into
a non-native modal with a scrollable textarea.
Fixes T7388
Test Plan: tested locally
Reviewers: jackie, juan
Reviewed By: juan
Maniphest Tasks: T7388
Differential Revision: https://phab.nylas.com/D3601
Summary:
We used to use a progress-based spinner, but we never get any progress
updates while downloading files, so the spinner was always at 0 and
never visible.
The submodule-commit is D3609, which adds support for inline images
Test Plan: tested locally
Reviewers: evan, spang
Reviewed By: spang
Differential Revision: https://phab.nylas.com/D3610
Summary: So that we know the status of builds
Test Plan: Run the build. See it post to slack
Reviewers: juan, evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D3607
Summary: More files that don't need linting
Test Plan: ... run the build
Reviewers: evan
Reviewed By: evan
Subscribers: juan, evan
Differential Revision: https://phab.nylas.com/D3599
Summary:
- Make creating/renaming categories non-optimistic (this, along with the
submodule commit D3593, prevents sub-categories with emtpy titles)
- Use SyncbackTaskAPIRequest in DestroyCategoryTask
- Don't get upset that renaming a category doesn't return a server id
Test Plan: local
Reviewers: juan, evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D3594
Summary: Second attempt at not linting the error logger and tiny lint cleanup
Test Plan: run the build
Reviewers: evan, juan
Reviewed By: juan
Differential Revision: https://phab.nylas.com/D3591
Summary:
- Handle `categories` if it exists, because clone() will call fromJSON()
on the results of toJSON(), which populates `categories` instead of
`folder` or `labels`
- Remove the else-if for `folder` and `labels`, because both can co-exist.
Also concatenate the results from these two, rathering than overwriting.
Submodule commit is D3581, these two diffs together help make sure the
inflated messages in N1 have the right categories.
Test Plan: tested locally
Reviewers: juan, evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D3582
Summary: Skipping linting for the error logger
Test Plan: Run the build
Reviewers: juan
Reviewed By: juan
Differential Revision: https://phab.nylas.com/D3583
refactor(send): split delivery from sent folder stuffing
Summary:
See explanation in https://phab.nylas.com/D3577
Depends on D3577
Test Plan: manual
Reviewers: jackie, juan, halla
Reviewed By: juan, halla
Differential Revision: https://phab.nylas.com/D3578
Summary:
We weren't removing the inbox category in the search perspective, so
things weren't actually being archived.
Test Plan: Run locally
Reviewers: juan, evan
Reviewed By: evan
Maniphest Tasks: T7389
Differential Revision: https://phab.nylas.com/D3575
Summary:
We want users to know that their account is still syncing if they're
looking for a message and end up at the bottom of a thread list.
This diff changes some of the wording around the messaging when
sync isn't complete and also adds a footer at the bottom of the
syncing thread lists. Additionally, we added a "Show Progress"
link that will expand the sync details in the lower left.
Addresses T7354
Test Plan: tested locally
Reviewers: juan, evan, jackie
Reviewed By: jackie
Differential Revision: https://phab.nylas.com/D3551
Summary: We weren't doing this which was causing us to deref undefined later.
Test Plan: Run locally
Reviewers: juan, evan
Maniphest Tasks: T7355
Differential Revision: https://phab.nylas.com/D3561
