Commit graph

1779 commits

Author SHA1 Message Date
Ben Gotow ec7aa08f10 Fix for broken thread serialization. We now coerce folders/labels => categories and never go back. 2016-01-18 01:47:09 -08:00
Ben Gotow 00ff8269da Make a few changes to AccountSidebar - needs to use accountIds? 2016-01-18 01:31:54 -08:00
Ben Gotow 99854add72 Remove current()? references, use Perspectiv.forNothing instead 2016-01-18 01:31:35 -08:00
Ben Gotow f1b4a23897 Merge branch 'unified-inbox-bg' into unified-inbox
# Conflicts:
#	internal_packages/account-sidebar/lib/account-sidebar-store.coffee
#	internal_packages/account-sidebar/lib/main.coffee
#	internal_packages/category-picker/lib/category-picker.cjsx
#	spec/stores/focused-perspective-store-spec.coffee
#	src/flux/stores/focused-perspective-store.coffee
#	src/mailbox-perspective.coffee
2016-01-18 00:53:03 -08:00
Ben Gotow 96f429ff39 Unified inbox mailbox perspectives working (sidebar disabled atm) 2016-01-18 00:47:04 -08:00
Juan Tejada ebb9c9735f AccountSidebar package refactor:
- Creates OutlineView generic component and uses that instead of custom
  code
- Refactors AccountSidebarStore:
  - Split the generation of the state tree into smaller functions
  - Adds different types of account sidebar items and sections, which contain
    logic and props necessary to be rendered as OutlineViewItems, and
    removes that logic from the store
- Removes WorkspaceStore.SidebarItem and removes the ability to register
  new sidebar items. If people want to add something to the sidebar they
  can just register a Component via the component registry and use the
  OutlineView component
- Removes the DraftListSidebarItem, which was basically duplicated code
  for an item but with a different data source. This is now handled
  generically by the account sidebar by rendering OutlineViewItems with
  different props and handlers
- Clean ups here and there:

- TODO
  - Add AccountSwitcher
  - Revisit calculation and generation of the state tree. Should the
    parent store contain and update the entire state all the time.
    Should separate items inside the tree have their own data sources?
  - This would avoid having the AccountSidebarStore listen to a bunch of
    different other stores, and the specific logic wold be contained
    inside each item type.
2016-01-15 16:55:21 -08:00
Ben Gotow 31f808ef35 WIP 2016-01-15 15:39:32 -08:00
Ben Gotow 774562dbc1 Clean up the MultiselectList implementation a bit 2016-01-15 14:26:07 -08:00
Ben Gotow 8957c560f5 More renaming of view => data source 2016-01-14 15:04:17 -08:00
Ben Gotow d78e61839d Some basic thread list cleanup 2016-01-14 14:04:51 -08:00
Ben Gotow ff01c3a502 DataView => ListDataSource 2016-01-14 12:26:54 -08:00
Ben Gotow c52e4bcd19 New QueryRange specs, fixes 2016-01-14 12:03:06 -08:00
Ben Gotow dc3c07014f New MutableQueyResultSet specs, fixes 2016-01-14 11:25:52 -08:00
Ben Gotow 3a8a38b8bc Merge branch 'master' into unified-inbox
# Conflicts:
#	spec/stores/file-download-store-spec.coffee
2016-01-13 17:20:34 -08:00
Ben Gotow 8cd3176574 build(linux): Ensure that target files are not group writable
Should fix #710. Will move all 0775 => 0755 and 0664 => 0644
2016-01-13 16:09:53 -08:00
Juan Tejada 6590848f35 Fix CategoryStore sorting:
- Also fix Category model specs
2016-01-13 14:20:44 -08:00
Drew Regitsky f469fd29d8 fix(templates): rewritten "welcome" file / example template 2016-01-13 12:08:41 -08:00
Ben Gotow 70c3c18ca5 fix(newsletter): Checkbox refreshes properly when switching accounts 2016-01-13 11:45:48 -08:00
Ben Gotow ad9242a387 Merge pull request #998 from nylas/set_s3_content_type
set the ContentType when uploading packages to S3.
2016-01-13 11:39:35 -08:00
Karim Hamidou 4ba827fc48 set the ContentType when uploading packages to S3. 2016-01-13 11:12:39 -08:00
Ben Gotow 7c749468e5 bump(version): 0.3.43 and changelog 2016-01-12 19:19:16 -08:00
Ben Gotow fb41a8184e fix(specs): Spec fixes for 37e1f6bb 2016-01-12 19:11:47 -08:00
Ben Gotow d78db0169c fix(contenteditable): exportedSelection isn't always an inst of ExportedSelection
This is a temporary fix that makes this function more robust to @innerState.exportedSelection not being an ExportedSelection instance.
2016-01-12 19:09:57 -08:00
Ben Gotow e8997b0944 fix(spellcheck): Unwrap nodes with simpler code with less side effects 2016-01-12 19:03:04 -08:00
Juan Tejada 0dd87c80d7 fix(warnings): Don't issue a warning for attachments when word attach in
signature

- Fixes #912
2016-01-12 18:45:27 -08:00
Ben Gotow 5ad35cf4d0 fix(unread): Mark as read twice without visiting another unread thread 2016-01-12 17:14:17 -08:00
Ben Gotow 3edf4854cd bump(version): 0.3.42 (testing Windows autorestart) 2016-01-12 15:58:37 -08:00
Ben Gotow f0bc344f0d bump(version): 0.3.41 2016-01-12 15:46:00 -08:00
Evan Morikawa 2f5a4f93bf fix(squirrel): remove apm from path 2016-01-12 18:36:44 -05:00
Evan Morikawa ef8759dd62 fix(lint): fix linter issues in template store 2016-01-12 18:33:01 -05:00
Evan Morikawa 9726618069 fix(squirrel): fix win32 update to enable restart and launch from path 2016-01-12 18:17:30 -05:00
Ben Gotow ba9af70b16 fix(accounts): Spec fixes for a03e8f70 2016-01-12 15:16:59 -08:00
Juan Tejada c10d22f163 fix(fullscreen): Restore fullscreen if app was closed in fullscreen
Fixes #671
2016-01-12 15:12:43 -08:00
Ben Gotow 84a0125260 fix(accounts): Load accounts before adding a new one 2016-01-12 15:08:56 -08:00
Ben Gotow cc2537b141 fix(sp): illegial => illegal 🙏 2016-01-12 14:39:16 -08:00
Ben Gotow 33d7cf5973 fix(paste): Keep <div> tags so pate between N1 emails works 2016-01-12 14:31:34 -08:00
Drew Regitsky 6cc0e6ca0d fix(templates): insert template no longer overwrites signature 2016-01-12 14:09:37 -08:00
Ben Gotow 5a12dde49c fix(drag): Drag and drop files with illegial path characters 2016-01-12 13:52:01 -08:00
Ben Gotow 8f45633fea fix(downloads): Escape all illegial path chars, don't make regex from path.sep 2016-01-12 13:52:01 -08:00
Ben Gotow 97d49256bd fix(packages): Default icon for third-party packages 2016-01-12 13:52:01 -08:00
Ben Gotow c72e5099aa fix(composer): whilePreservingSelection should not call select if not activeElement 2016-01-12 13:52:01 -08:00
Ben Gotow 67a448db5d fix(selection): ExportedSelection must properly represent "None" 2016-01-12 13:52:01 -08:00
Juan Tejada 646785e182 fix(styles): Add bottom margin to templates plugin message 2016-01-12 13:46:50 -08:00
Drew Regitsky c91a0c6062 fix(templates): fix several bugs in templates plugin
Fixes behavior when there are no template files, prevents renaming/creating
with an empty name, fixes yet another way to accidentally make yellow text,
misc small style fixes
2016-01-12 12:44:38 -08:00
Juan Tejada 57aee26256 fix(composer): Fix focus behavior when signature present and when
clicking outside:

- When focusing the composer via click inside the contenteditable region or via
tabbing, last text node before the signature (or blockquotes) will be focused.
- When focusing composer by clicking outside contenteditable region, it
  will default to default contenteditable focus behavior via new method:
  `nativeFocus`
2016-01-12 12:36:19 -08:00
Ben Gotow c7ebbb189b fix(indicators): Remove duplicate description key 2016-01-12 10:28:34 -08:00
Ben Gotow 69ca8cf0e6 fix(readme): Remove link to plugins repo 2016-01-12 10:18:41 -08:00
Juan Tejada cec3b38d1d Update names to use perspective instead of view 2016-01-12 09:49:56 -08:00
Ben Gotow 3d9e412fda Perf: Category
Rather than computing the types ahead of time when the object is created and generating methods, keep a few standard methods around and change the hardcoded names to maps so the lookup is O[1]
2016-01-12 09:32:34 -08:00
Ben Gotow 0d132023d2 Perf for thread list. See description
- ComponentRegistry: findComponentsMatching often returns zero results but makes a lot of transient data structures. Add a cache to make it O[1]

- Contact isMe is called a zillion times to compute thread participant display. Checking the AccountStore had been required was slow.

- getStandardCategory is also called a ton. Rather than create a filtered array and then searching that, just search the existing array.
2016-01-12 09:10:52 -08:00