Commit graph

2117 commits

Author SHA1 Message Date
Evan Morikawa fb4e806afe feat(menu): add right click menu
Summary:
Adds a right click menu to the thread list
Moving to folders and labels #TODO

Test Plan: TODO

Reviewers: bengotow, juan

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2609
2016-02-19 18:35:48 -05:00
Ben Gotow 95aba56979 fix(sending): Tiny fix for strange vertical space when sending 2016-02-19 15:31:51 -08:00
Bernd Verst 34f530ce71 Changes the Gmail auth domain from edgehill.nylas.com to n1-auth.nylas.com
Summary: Changes the Gmail auth domain from edgehill.nylas.com to n1-auth.nylas.com. This URL is displayed in the browser.

Test Plan: Manually built N1 and verified signin flow works with new subdomain.

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2540
2016-02-19 14:50:36 -08:00
Juan Tejada 703d7bc2e0 fix(transaction): Trigger changes only after COMMIT has been executed
- Fixes #1327
- This caused the dataase query inside QuerySubscription to, on occassion,
  return stale results from the database because the database hadn't
  finished writing. This consequently caused the QuerySubscription to
  build and incorrect result set.
2016-02-19 13:24:04 -08:00
Drew Regitsky 199a62d70e feat(new-plugins): add open tracking and link tracking plugins
Summary:
Adds two (very similar) plugins - Open Tracking and Link Tracking.
Both can be enabled via a button in the composer. Open tracking
inserts a tracking pixel right before send, and link tracking replaces
all links with tracked redirects. Both plugins use the new Metadata
service to store their open/click counts, and have backend servers to
respectively serve the pixel image or handle the redirects. Requests
also trigger a metadata update to increment the open/click counters.

Test Plan: Manual for now

Reviewers: evan, bengotow, drew

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2583
2016-02-19 12:42:56 -08:00
Juan Tejada aedc09b2b3 fix(metadata): Correctly call modelify for latest models when setting metadata 2016-02-19 11:54:02 -08:00
Ben Gotow b65c4104b4 lint(emoji): Fix lint failure from spacing 2016-02-19 11:29:31 -08:00
Karim Hamidou 97f968a808 [auth] Change a Google OAuth parameter
Summary:
Some of our users who reauth are getting weird errors from Google — it seems that in some cases Google OAuth doesn’t pass us a `refresh_token`, even though we ask for one by passing `approval_prompt=force` (I’ve landed a commit to log more details about this in edgehill-server —- 6e984ffa26 — but this won’t fix the problem).

Apparently, Google recently « soft-deprecated » `approval_prompt` in favor of a new parameter called `prompt`, which does mostly the same thing (https://developers.google.com/identity/protocols/OAuth2WebServer#formingtheurl)

This diff replaces `approval_prompt` by `prompt`.

Test Plan: Tested by authing a Gmail account and checking that it worked.

Reviewers: bengotow

Reviewed By: bengotow

Subscribers: emfree

Differential Revision: https://phab.nylas.com/D2557
2016-02-19 11:20:36 -08:00
Ben Gotow 98529dc7a8 fix(participants): Update specs to reflect that spacing is now in CSS 2016-02-19 10:28:02 -08:00
Ben Gotow c3ca9c4a9e fix(launchscreen): hack until renderer sync fixed upstream 2016-02-18 16:09:30 -08:00
Ben Gotow d722153de7 fix(lint): LESS lint issues 2016-02-18 15:49:45 -08:00
Ben Gotow b6a1674173 💄: White buttons, dropdown / popover cleanup, hairline dividers 2016-02-18 15:21:42 -08:00
Michael Grinich a673a698fd Merge pull request #1350 from jamiewilson/patch-1
Adding Darkside theme
2016-02-18 15:23:25 -06:00
Juan Tejada 74bb98b337 fix(draft-list): Display , separated participants list 2016-02-18 12:14:18 -08:00
Juan Tejada d0bdeb3a02 🎨(composer): Fix show-more token style in collapsed participants 2016-02-18 12:06:29 -08:00
Juan Tejada 9f820854d4 fix(issue-template): Update formatting 2016-02-18 11:05:13 -08:00
Juan Tejada bb52510c87 fix(snooze): Check if snooze category is defined when creating 2016-02-18 10:44:03 -08:00
Juan Tejada a841417011 feat(snooze/send-later): Add snooze and send later plugins
Summary:
- Add initial version of snooze and send later plugins
- Tests are missing since this will probably heavily change before we are done with them

Test Plan: - TODO

Reviewers: drew, bengotow, evan

Reviewed By: bengotow, evan

Differential Revision: https://phab.nylas.com/D2578
2016-02-18 10:06:21 -08:00
Ben Gotow 21ce6355a5 gh: Issue template isn't actually displayed as markdown 2016-02-18 10:03:18 -08:00
Ben Gotow 42d43cf802 gh: Initial commit of issue template 2016-02-18 09:55:52 -08:00
Ben Gotow 7ca844bd75 fix(onboarding): Missing require for Actions, bad CSS 2016-02-17 22:21:23 -08:00
Juan Tejada 0217e5a509 feat(metadata): Switch to storing metadata on models
Summary:
 - Adds a class ModelWithMetadata which models can now extend from
 - Instances of this class can query metadata for a plugin via
   `obj.metadataForPluginId(pluginId)`
 - To observe changes on metadata it is sufficient to observe database changes on
   the model. e.g.:
   `DatabaseStore.findAll(Thread,
   [Thread.attributes.pluginMetadata.contains(pluginId)])`
 - To set metadata a new action has been created: Actions.setMetadata
 - Adds a helper observable in nylas-observables to query for models with
   metadata
 - Merges CreateModelTask and UpdateModelTask into SyncbackModelTask
 - Update SendDraftTask ans SynbackDraftTask to handle metadata changes

Test Plan: - Unit tests

Reviewers: drew, evan, bengotow

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2575
2016-02-17 15:00:33 -08:00
Michael Grinich 458b0fbe91 Add Waffle.io on deck badge to README 2016-02-16 20:24:17 -08:00
Juan Tejada 7ca04c579e fix(account-prefs): Update account save logic to prevent incorrect saves
- This fixes #1354 and #1235
- This issue was caused because the account details preferences
  component was keeping as state all of the account object fields. `setState` works
  like `extend`, so when the account changed, state was set to the new set of account fields,
  but the old values were only removed if they were overriden, and remained the
  same if the field did not exist in the new state object.
  Specifically, when a new account was added, setState was called with
  `{..., defaultAlias: undefined}` which did /not/ remove the  the defaultAlias
  from the previous state.
- Switched to managing state with a top level key `account`
2016-02-16 18:03:22 -08:00
Juan Tejada 139f25e12f fix(account-store): Update focused perspective after triggering
- This prevents account store changes from propagating in the incorrect
  order
2016-02-16 17:26:45 -08:00
Ben Gotow 8f6dff7da8 fix(important): Remove todo, reference to usesImportantFlag. Fixes #1331 2016-02-16 11:41:15 -08:00
Ben Gotow a9f7274bcf fix(undo): Queuing an empty array should not trigger undo-redo store 2016-02-16 11:40:23 -08:00
Jamie Wilson 38e4765eac Adding Darkside theme
Can be seen here: http://jamiewilson.io/darkside/ and here: https://github.com/jamiewilson/darkside
2016-02-16 13:31:29 -06:00
Ben Gotow cc686feabb Merge pull request #1324 from sethvargo/sethvargo/apple_mail
More closely match Apple mail shortcuts
2016-02-16 09:43:15 -08:00
Juan Tejada 8b4c660c10 fix(mail-rules): Fix undefined reference to ReprocessMailRulesTask 2016-02-15 16:53:33 -08:00
Seth Vargo 752e0bb25a More closely match Apple mail shortcuts 2016-02-15 18:14:05 -05:00
Evan Morikawa 3298a38d6a fix(composer): fix dissapearing participant bug w/ multiple composers
If you had multiple composers on a single thread, all but the last
composer would lose its participants. This was because once it loaded the
participants would blur and trigger a request to set the participants to
blank. That request was async so by the time it was resolved the draft was
loaded and the request erroneously went through
2016-02-15 18:12:41 -05:00
Evan Morikawa 58d3c1d7cf fix(onboarding): remove ssl-enabled checkbox
Until it's implemented in the backend
2016-02-15 16:51:02 -05:00
Evan Morikawa 60f7290564 fix(messages): fix jumping message list on draft focus
We were erroneously jumping to an individual message when you focused on
it.
2016-02-15 16:34:23 -05:00
Evan Morikawa d80edbf7f3 fix(message): fix collapse unset when new thread delta
The minification bit was erroneously getting reset when a new thread
update delta came in due to an object equality check instead of an id
check.
2016-02-15 15:46:33 -05:00
Evan Morikawa 10564db50a fix(analytics): no longer track tasks 2016-02-12 13:52:06 -08:00
Evan Morikawa 42204ddecf fix(composer): allow link paste without tooltip
Also fix style issues with link text.

Fix cmd+k link editing when nothing is selected.

Make confirm button only appear when there are changes to be made
2016-02-12 13:50:20 -08:00
Jackie Luo 7bbd41bea4 fix(composer-emojis): Add spec, allow adjacent emojis, fix toolbar positioning bug
Summary:
Adds tests to the emoji picker.

The emoji picker should also now be able to add emojis consecutively (without spaces).

Finally, the toolbar positioning bug (emoji picker appearing in front of typed text, the toolbar manager appearing in the upper left corner when empty lines are selected) should be fixed so that the toolbar appears directly above/below the selection area.

Test Plan: Tests included in diff.

Reviewers: evan, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2551
2016-02-12 11:42:11 -08:00
Evan Morikawa 5f1b8633c7 fix(analytics): delay closing of onboarding window 2016-02-12 10:56:36 -08:00
Evan Morikawa ac52589de5 fix(analytics): add onboarding welcome event 2016-02-12 10:25:28 -08:00
Ben Gotow daa2a66063 fix(outline-view): Make text larger in the sidebar 2016-02-12 10:20:14 -08:00
Ben Gotow 226cf4ce64 fix(search): Compile immediately to avoid truncating. Fixes #1307 2016-02-11 17:18:24 -08:00
Evan Morikawa 9021b02a6c fix(win): bump windows-shortcuts 2016-02-11 17:15:15 -08:00
Evan Morikawa 6fbb7f73d3 fix(win): bump windows-shortcuts fork 2016-02-11 16:53:59 -08:00
Ben Gotow 2de93c614b fix(contacts): Stop auto-capitalizing phrases and emails. Fixes #1308 2016-02-11 16:30:28 -08:00
Ben Gotow 03a33e5270 🎨: Fixes, labels in narrow thread view, better label wrap 2016-02-11 15:25:24 -08:00
Evan Morikawa aaf68b25c8 fix(win): add windows-shortcuts to asar exclude 2016-02-11 13:52:53 -08:00
Juan Tejada c4135ee23c 🎨(popover): Remove hardcoded width from code -> move to stylesheet 2016-02-11 13:15:59 -08:00
Drew Regitsky ab527ab3a5 fix(plugin-auth): more fixes to plugin auth 2016-02-10 17:47:10 -08:00
Ben Gotow e91c9b82f5 Merge pull request #1283 from rittbys/master
Change the title bar to say Nylas N1 instead of Nylas
2016-02-10 14:39:13 -08:00