mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-21 07:46:06 +08:00
1e8fd46342
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
462 lines
19 KiB
CoffeeScript
462 lines
19 KiB
CoffeeScript
path = require 'path'
|
|
|
|
{$, $$} = require '../src/space-pen-extensions'
|
|
fs = require 'fs-plus'
|
|
temp = require 'temp'
|
|
|
|
ThemeManager = require '../src/theme-manager'
|
|
Package = require '../src/package'
|
|
|
|
describe "ThemeManager", ->
|
|
themeManager = null
|
|
resourcePath = atom.getLoadSettings().resourcePath
|
|
configDirPath = atom.getConfigDirPath()
|
|
|
|
beforeEach ->
|
|
themeManager = new ThemeManager({packageManager: atom.packages, resourcePath, configDirPath})
|
|
|
|
afterEach ->
|
|
themeManager.deactivateThemes()
|
|
|
|
describe "theme getters and setters", ->
|
|
beforeEach ->
|
|
jasmine.snapshotDeprecations()
|
|
atom.packages.loadPackages()
|
|
|
|
afterEach ->
|
|
jasmine.restoreDeprecationsSnapshot()
|
|
|
|
it 'getLoadedThemes get all the loaded themes', ->
|
|
themes = themeManager.getLoadedThemes()
|
|
expect(themes.length).toBeGreaterThan(2)
|
|
|
|
it 'getActiveThemes get all the active themes', ->
|
|
waitsForPromise ->
|
|
themeManager.activateThemes()
|
|
|
|
runs ->
|
|
names = atom.config.get('core.themes')
|
|
expect(names.length).toBeGreaterThan(0)
|
|
themes = themeManager.getActiveThemes()
|
|
expect(themes).toHaveLength(names.length)
|
|
|
|
describe "when the core.themes config value contains invalid entry", ->
|
|
it "ignores theme", ->
|
|
atom.config.set 'core.themes', [
|
|
'atom-light-ui'
|
|
null
|
|
undefined
|
|
''
|
|
false
|
|
4
|
|
{}
|
|
[]
|
|
'atom-dark-ui'
|
|
]
|
|
|
|
expect(themeManager.getEnabledThemeNames()).toEqual ['atom-dark-ui', 'atom-light-ui']
|
|
|
|
describe "::getImportPaths()", ->
|
|
it "returns the theme directories before the themes are loaded", ->
|
|
atom.config.set('core.themes', ['theme-with-index-less', 'atom-dark-ui', 'atom-light-ui'])
|
|
|
|
paths = themeManager.getImportPaths()
|
|
|
|
# syntax theme is not a dir at this time, so only two.
|
|
expect(paths.length).toBe 2
|
|
expect(paths[0]).toContain 'atom-light-ui'
|
|
expect(paths[1]).toContain 'atom-dark-ui'
|
|
|
|
it "ignores themes that cannot be resolved to a directory", ->
|
|
atom.config.set('core.themes', ['definitely-not-a-theme'])
|
|
expect(-> themeManager.getImportPaths()).not.toThrow()
|
|
|
|
describe "when the core.themes config value changes", ->
|
|
it "add/removes stylesheets to reflect the new config value", ->
|
|
themeManager.onDidChangeActiveThemes didChangeActiveThemesHandler = jasmine.createSpy()
|
|
spyOn(atom.styles, 'getUserStyleSheetPath').andCallFake -> null
|
|
|
|
waitsForPromise ->
|
|
themeManager.activateThemes()
|
|
|
|
runs ->
|
|
didChangeActiveThemesHandler.reset()
|
|
atom.config.set('core.themes', [])
|
|
|
|
waitsFor ->
|
|
didChangeActiveThemesHandler.callCount == 1
|
|
|
|
runs ->
|
|
didChangeActiveThemesHandler.reset()
|
|
expect($('style.theme')).toHaveLength 0
|
|
atom.config.set('core.themes', ['atom-dark-ui'])
|
|
|
|
waitsFor ->
|
|
didChangeActiveThemesHandler.callCount == 1
|
|
|
|
runs ->
|
|
didChangeActiveThemesHandler.reset()
|
|
expect($('style[priority=1]')).toHaveLength 2
|
|
expect($('style[priority=1]:eq(0)').attr('source-path')).toMatch /atom-dark-ui/
|
|
atom.config.set('core.themes', ['atom-light-ui', 'atom-dark-ui'])
|
|
|
|
waitsFor ->
|
|
didChangeActiveThemesHandler.callCount == 1
|
|
|
|
runs ->
|
|
didChangeActiveThemesHandler.reset()
|
|
expect($('style[priority=1]')).toHaveLength 2
|
|
expect($('style[priority=1]:eq(0)').attr('source-path')).toMatch /atom-dark-ui/
|
|
expect($('style[priority=1]:eq(1)').attr('source-path')).toMatch /atom-light-ui/
|
|
atom.config.set('core.themes', [])
|
|
|
|
waitsFor ->
|
|
didChangeActiveThemesHandler.callCount == 1
|
|
|
|
runs ->
|
|
didChangeActiveThemesHandler.reset()
|
|
expect($('style[priority=1]')).toHaveLength 2
|
|
# atom-dark-ui has an directory path, the syntax one doesn't
|
|
atom.config.set('core.themes', ['theme-with-index-less', 'atom-dark-ui'])
|
|
|
|
waitsFor ->
|
|
didChangeActiveThemesHandler.callCount == 1
|
|
|
|
runs ->
|
|
expect($('style[priority=1]')).toHaveLength 2
|
|
importPaths = themeManager.getImportPaths()
|
|
expect(importPaths.length).toBe 1
|
|
expect(importPaths[0]).toContain 'atom-dark-ui'
|
|
|
|
it 'adds theme-* classes to the workspace for each active theme', ->
|
|
workspaceElement = atom.views.getView(atom.workspace)
|
|
themeManager.onDidChangeActiveThemes didChangeActiveThemesHandler = jasmine.createSpy()
|
|
|
|
waitsForPromise ->
|
|
themeManager.activateThemes()
|
|
|
|
runs ->
|
|
expect(workspaceElement).toHaveClass 'theme-atom-dark-ui'
|
|
|
|
themeManager.onDidChangeActiveThemes didChangeActiveThemesHandler = jasmine.createSpy()
|
|
atom.config.set('core.themes', ['theme-with-ui-variables', 'theme-with-syntax-variables'])
|
|
|
|
waitsFor ->
|
|
didChangeActiveThemesHandler.callCount > 0
|
|
|
|
runs ->
|
|
# `theme-` twice as it prefixes the name with `theme-`
|
|
expect(workspaceElement).toHaveClass 'theme-theme-with-ui-variables'
|
|
expect(workspaceElement).toHaveClass 'theme-theme-with-syntax-variables'
|
|
expect(workspaceElement).not.toHaveClass 'theme-atom-dark-ui'
|
|
expect(workspaceElement).not.toHaveClass 'theme-atom-dark-syntax'
|
|
|
|
describe "when a theme fails to load", ->
|
|
it "logs a warning", ->
|
|
spyOn(console, 'warn')
|
|
atom.packages.activatePackage('a-theme-that-will-not-be-found')
|
|
expect(console.warn.callCount).toBe 1
|
|
expect(console.warn.argsForCall[0][0]).toContain "Could not resolve 'a-theme-that-will-not-be-found'"
|
|
|
|
describe "::requireStylesheet(path)", ->
|
|
beforeEach ->
|
|
jasmine.snapshotDeprecations()
|
|
|
|
afterEach ->
|
|
jasmine.restoreDeprecationsSnapshot()
|
|
|
|
it "synchronously loads css at the given path and installs a style tag for it in the head", ->
|
|
atom.styles.onDidAddStyleElement styleElementAddedHandler = jasmine.createSpy("styleElementAddedHandler")
|
|
themeManager.onDidChangeStylesheets stylesheetsChangedHandler = jasmine.createSpy("stylesheetsChangedHandler")
|
|
themeManager.onDidAddStylesheet stylesheetAddedHandler = jasmine.createSpy("stylesheetAddedHandler")
|
|
|
|
cssPath = atom.project.getDirectories()[0]?.resolve('css.css')
|
|
lengthBefore = $('head style').length
|
|
|
|
themeManager.requireStylesheet(cssPath)
|
|
expect($('head style').length).toBe lengthBefore + 1
|
|
|
|
expect(styleElementAddedHandler).toHaveBeenCalled()
|
|
expect(stylesheetAddedHandler).toHaveBeenCalled()
|
|
expect(stylesheetsChangedHandler).toHaveBeenCalled()
|
|
|
|
element = $('head style[source-path*="css.css"]')
|
|
expect(element.attr('source-path')).toBe themeManager.stringToId(cssPath)
|
|
expect(element.text()).toBe fs.readFileSync(cssPath, 'utf8')
|
|
expect(element[0].sheet).toBe stylesheetAddedHandler.argsForCall[0][0]
|
|
|
|
# doesn't append twice
|
|
styleElementAddedHandler.reset()
|
|
themeManager.requireStylesheet(cssPath)
|
|
expect($('head style').length).toBe lengthBefore + 1
|
|
expect(styleElementAddedHandler).not.toHaveBeenCalled()
|
|
|
|
$('head style[id*="css.css"]').remove()
|
|
|
|
it "synchronously loads and parses less files at the given path and installs a style tag for it in the head", ->
|
|
lessPath = atom.project.getDirectories()[0]?.resolve('sample.less')
|
|
lengthBefore = $('head style').length
|
|
themeManager.requireStylesheet(lessPath)
|
|
expect($('head style').length).toBe lengthBefore + 1
|
|
|
|
element = $('head style[source-path*="sample.less"]')
|
|
expect(element.attr('source-path')).toBe themeManager.stringToId(lessPath)
|
|
expect(element.text()).toBe """
|
|
#header {
|
|
color: #4d926f;
|
|
}
|
|
h2 {
|
|
color: #4d926f;
|
|
}
|
|
|
|
"""
|
|
|
|
# doesn't append twice
|
|
themeManager.requireStylesheet(lessPath)
|
|
expect($('head style').length).toBe lengthBefore + 1
|
|
$('head style[id*="sample.less"]').remove()
|
|
|
|
it "supports requiring css and less stylesheets without an explicit extension", ->
|
|
themeManager.requireStylesheet path.join(__dirname, 'fixtures', 'css')
|
|
expect($('head style[source-path*="css.css"]').attr('source-path')).toBe themeManager.stringToId(atom.project.getDirectories()[0]?.resolve('css.css'))
|
|
themeManager.requireStylesheet path.join(__dirname, 'fixtures', 'sample')
|
|
expect($('head style[source-path*="sample.less"]').attr('source-path')).toBe themeManager.stringToId(atom.project.getDirectories()[0]?.resolve('sample.less'))
|
|
|
|
$('head style[id*="css.css"]').remove()
|
|
$('head style[id*="sample.less"]').remove()
|
|
|
|
it "returns a disposable allowing styles applied by the given path to be removed", ->
|
|
cssPath = require.resolve('./fixtures/css.css')
|
|
|
|
expect($(document.body).css('font-weight')).not.toBe("bold")
|
|
disposable = themeManager.requireStylesheet(cssPath)
|
|
expect($(document.body).css('font-weight')).toBe("bold")
|
|
|
|
atom.styles.onDidRemoveStyleElement styleElementRemovedHandler = jasmine.createSpy("styleElementRemovedHandler")
|
|
themeManager.onDidRemoveStylesheet stylesheetRemovedHandler = jasmine.createSpy("stylesheetRemovedHandler")
|
|
themeManager.onDidChangeStylesheets stylesheetsChangedHandler = jasmine.createSpy("stylesheetsChangedHandler")
|
|
|
|
disposable.dispose()
|
|
|
|
expect($(document.body).css('font-weight')).not.toBe("bold")
|
|
|
|
expect(styleElementRemovedHandler).toHaveBeenCalled()
|
|
expect(stylesheetRemovedHandler).toHaveBeenCalled()
|
|
stylesheet = stylesheetRemovedHandler.argsForCall[0][0]
|
|
expect(stylesheet instanceof CSSStyleSheet).toBe true
|
|
expect(stylesheet.cssRules[0].selectorText).toBe 'body'
|
|
|
|
expect(stylesheetsChangedHandler).toHaveBeenCalled()
|
|
|
|
describe "base style sheet loading", ->
|
|
workspaceElement = null
|
|
beforeEach ->
|
|
workspaceElement = atom.views.getView(atom.workspace)
|
|
jasmine.attachToDOM(workspaceElement)
|
|
workspaceElement.appendChild document.createElement('atom-text-editor')
|
|
|
|
waitsForPromise ->
|
|
themeManager.activateThemes()
|
|
|
|
it "loads the correct values from the theme's ui-variables file", ->
|
|
themeManager.onDidChangeActiveThemes didChangeActiveThemesHandler = jasmine.createSpy()
|
|
atom.config.set('core.themes', ['theme-with-ui-variables', 'theme-with-syntax-variables'])
|
|
|
|
waitsFor ->
|
|
didChangeActiveThemesHandler.callCount > 0
|
|
|
|
runs ->
|
|
# an override loaded in the base css
|
|
expect(getComputedStyle(workspaceElement)["background-color"]).toBe "rgb(0, 0, 255)"
|
|
|
|
# from within the theme itself
|
|
expect($("atom-text-editor").css("padding-top")).toBe "150px"
|
|
expect($("atom-text-editor").css("padding-right")).toBe "150px"
|
|
expect($("atom-text-editor").css("padding-bottom")).toBe "150px"
|
|
|
|
describe "when there is a theme with incomplete variables", ->
|
|
it "loads the correct values from the fallback ui-variables", ->
|
|
themeManager.onDidChangeActiveThemes didChangeActiveThemesHandler = jasmine.createSpy()
|
|
atom.config.set('core.themes', ['theme-with-incomplete-ui-variables', 'theme-with-syntax-variables'])
|
|
|
|
waitsFor ->
|
|
didChangeActiveThemesHandler.callCount > 0
|
|
|
|
runs ->
|
|
# an override loaded in the base css
|
|
expect(getComputedStyle(workspaceElement)["background-color"]).toBe "rgb(0, 0, 255)"
|
|
|
|
# from within the theme itself
|
|
expect($("atom-text-editor").css("background-color")).toBe "rgb(0, 152, 255)"
|
|
|
|
describe "user stylesheet", ->
|
|
userStylesheetPath = null
|
|
beforeEach ->
|
|
userStylesheetPath = path.join(temp.mkdirSync("atom"), 'styles.less')
|
|
fs.writeFileSync(userStylesheetPath, 'body {border-style: dotted !important;}')
|
|
spyOn(atom.styles, 'getUserStyleSheetPath').andReturn userStylesheetPath
|
|
|
|
describe "when the user stylesheet changes", ->
|
|
beforeEach ->
|
|
jasmine.snapshotDeprecations()
|
|
|
|
afterEach ->
|
|
jasmine.restoreDeprecationsSnapshot()
|
|
|
|
it "reloads it", ->
|
|
[styleElementAddedHandler, styleElementRemovedHandler] = []
|
|
[stylesheetRemovedHandler, stylesheetAddedHandler, stylesheetsChangedHandler] = []
|
|
|
|
waitsForPromise ->
|
|
themeManager.activateThemes()
|
|
|
|
runs ->
|
|
atom.styles.onDidRemoveStyleElement styleElementRemovedHandler = jasmine.createSpy("styleElementRemovedHandler")
|
|
atom.styles.onDidAddStyleElement styleElementAddedHandler = jasmine.createSpy("styleElementAddedHandler")
|
|
|
|
themeManager.onDidChangeStylesheets stylesheetsChangedHandler = jasmine.createSpy("stylesheetsChangedHandler")
|
|
themeManager.onDidRemoveStylesheet stylesheetRemovedHandler = jasmine.createSpy("stylesheetRemovedHandler")
|
|
themeManager.onDidAddStylesheet stylesheetAddedHandler = jasmine.createSpy("stylesheetAddedHandler")
|
|
spyOn(themeManager, 'loadUserStylesheet').andCallThrough()
|
|
|
|
expect($(document.body).css('border-style')).toBe 'dotted'
|
|
fs.writeFileSync(userStylesheetPath, 'body {border-style: dashed}')
|
|
|
|
waitsFor ->
|
|
themeManager.loadUserStylesheet.callCount is 1
|
|
|
|
runs ->
|
|
expect($(document.body).css('border-style')).toBe 'dashed'
|
|
|
|
expect(styleElementRemovedHandler).toHaveBeenCalled()
|
|
expect(styleElementRemovedHandler.argsForCall[0][0].textContent).toContain 'dotted'
|
|
expect(stylesheetRemovedHandler).toHaveBeenCalled()
|
|
expect(stylesheetRemovedHandler.argsForCall[0][0].cssRules[0].style.border).toBe 'dotted'
|
|
|
|
expect(styleElementAddedHandler).toHaveBeenCalled()
|
|
expect(styleElementAddedHandler.argsForCall[0][0].textContent).toContain 'dashed'
|
|
expect(stylesheetAddedHandler).toHaveBeenCalled()
|
|
expect(stylesheetAddedHandler.argsForCall[0][0].cssRules[0].style.border).toBe 'dashed'
|
|
|
|
expect(stylesheetsChangedHandler).toHaveBeenCalled()
|
|
|
|
styleElementRemovedHandler.reset()
|
|
stylesheetRemovedHandler.reset()
|
|
stylesheetsChangedHandler.reset()
|
|
fs.removeSync(userStylesheetPath)
|
|
|
|
waitsFor ->
|
|
themeManager.loadUserStylesheet.callCount is 2
|
|
|
|
runs ->
|
|
expect(styleElementRemovedHandler).toHaveBeenCalled()
|
|
expect(styleElementRemovedHandler.argsForCall[0][0].textContent).toContain 'dashed'
|
|
expect(stylesheetRemovedHandler).toHaveBeenCalled()
|
|
expect(stylesheetRemovedHandler.argsForCall[0][0].cssRules[0].style.border).toBe 'dashed'
|
|
expect($(document.body).css('border-style')).toBe 'none'
|
|
expect(stylesheetsChangedHandler).toHaveBeenCalled()
|
|
|
|
describe "when there is an error reading the stylesheet", ->
|
|
addErrorHandler = null
|
|
beforeEach ->
|
|
themeManager.loadUserStylesheet()
|
|
spyOn(themeManager.lessCache, 'cssForFile').andCallFake ->
|
|
throw new Error('EACCES permission denied "styles.less"')
|
|
atom.notifications.onDidAddNotification addErrorHandler = jasmine.createSpy()
|
|
|
|
it "creates an error notification and does not add the stylesheet", ->
|
|
themeManager.loadUserStylesheet()
|
|
expect(addErrorHandler).toHaveBeenCalled()
|
|
note = addErrorHandler.mostRecentCall.args[0]
|
|
expect(note.getType()).toBe 'error'
|
|
expect(note.getMessage()).toContain 'Error loading'
|
|
expect(atom.styles.styleElementsBySourcePath[atom.styles.getUserStyleSheetPath()]).toBeUndefined()
|
|
|
|
describe "when there is an error watching the user stylesheet", ->
|
|
addErrorHandler = null
|
|
beforeEach ->
|
|
{File} = require 'pathwatcher'
|
|
spyOn(File::, 'on').andCallFake (event) ->
|
|
if event.indexOf('contents-changed') > -1
|
|
throw new Error('Unable to watch path')
|
|
spyOn(themeManager, 'loadStylesheet').andReturn ''
|
|
atom.notifications.onDidAddNotification addErrorHandler = jasmine.createSpy()
|
|
|
|
it "creates an error notification", ->
|
|
themeManager.loadUserStylesheet()
|
|
expect(addErrorHandler).toHaveBeenCalled()
|
|
note = addErrorHandler.mostRecentCall.args[0]
|
|
expect(note.getType()).toBe 'error'
|
|
expect(note.getMessage()).toContain 'Unable to watch path'
|
|
|
|
describe "when a non-existent theme is present in the config", ->
|
|
beforeEach ->
|
|
spyOn(console, 'warn')
|
|
atom.config.set('core.themes', ['non-existent-dark-ui', 'non-existent-dark-syntax'])
|
|
|
|
waitsForPromise ->
|
|
themeManager.activateThemes()
|
|
|
|
it 'uses the default dark UI and syntax themes and logs a warning', ->
|
|
activeThemeNames = themeManager.getActiveThemeNames()
|
|
expect(console.warn.callCount).toBe 2
|
|
expect(activeThemeNames.length).toBe(2)
|
|
expect(activeThemeNames).toContain('atom-dark-ui')
|
|
expect(activeThemeNames).toContain('atom-dark-syntax')
|
|
|
|
describe "when in safe mode", ->
|
|
beforeEach ->
|
|
themeManager = new ThemeManager({packageManager: atom.packages, resourcePath, configDirPath, safeMode: true})
|
|
|
|
describe 'when the enabled UI and syntax themes are bundled with Atom', ->
|
|
beforeEach ->
|
|
atom.config.set('core.themes', ['atom-light-ui', 'atom-dark-syntax'])
|
|
|
|
waitsForPromise ->
|
|
themeManager.activateThemes()
|
|
|
|
it 'uses the enabled themes', ->
|
|
activeThemeNames = themeManager.getActiveThemeNames()
|
|
expect(activeThemeNames.length).toBe(2)
|
|
expect(activeThemeNames).toContain('atom-light-ui')
|
|
expect(activeThemeNames).toContain('atom-dark-syntax')
|
|
|
|
describe 'when the enabled UI and syntax themes are not bundled with Atom', ->
|
|
beforeEach ->
|
|
atom.config.set('core.themes', ['installed-dark-ui', 'installed-dark-syntax'])
|
|
|
|
waitsForPromise ->
|
|
themeManager.activateThemes()
|
|
|
|
it 'uses the default dark UI and syntax themes', ->
|
|
activeThemeNames = themeManager.getActiveThemeNames()
|
|
expect(activeThemeNames.length).toBe(2)
|
|
expect(activeThemeNames).toContain('atom-dark-ui')
|
|
expect(activeThemeNames).toContain('atom-dark-syntax')
|
|
|
|
describe 'when the enabled UI theme is not bundled with Atom', ->
|
|
beforeEach ->
|
|
atom.config.set('core.themes', ['installed-dark-ui', 'atom-light-syntax'])
|
|
|
|
waitsForPromise ->
|
|
themeManager.activateThemes()
|
|
|
|
it 'uses the default dark UI theme', ->
|
|
activeThemeNames = themeManager.getActiveThemeNames()
|
|
expect(activeThemeNames.length).toBe(2)
|
|
expect(activeThemeNames).toContain('atom-dark-ui')
|
|
expect(activeThemeNames).toContain('atom-light-syntax')
|
|
|
|
describe 'when the enabled syntax theme is not bundled with Atom', ->
|
|
beforeEach ->
|
|
atom.config.set('core.themes', ['atom-light-ui', 'installed-dark-syntax'])
|
|
|
|
waitsForPromise ->
|
|
themeManager.activateThemes()
|
|
|
|
it 'uses the default dark syntax theme', ->
|
|
activeThemeNames = themeManager.getActiveThemeNames()
|
|
expect(activeThemeNames.length).toBe(2)
|
|
expect(activeThemeNames).toContain('atom-light-ui')
|
|
expect(activeThemeNames).toContain('atom-dark-syntax')
|