Mailspring/internal_packages/composer/lib
Ben Gotow 9099542643 fix(quoted-text): div vs blockquote, signature cleanup #1746
Summary:
Previously we always created <blockquote class="gmail_quote"> to wrap quoted text. This is not correct.
Gmail uses blockquotes only when it wants visual indentation, and <div>s to wrap other quoted text, like forwarded
messages which are not displayed indented.

This diff updates N1 to match Gmail exactly. Note that for replies, Gmail actually nests a blockquote.gmail_quote
inside a div.gmail_quote.

I also updated signature handling because it turns out the regexp that was removing existing signatures would blow
away any and all divs until it reached a <blockquote> tag.

Test Plan: See updated specs. Manually tested by creating a thread in Google Inbox and then performing fwd and reply in both N1 and Inbox. Results match.

Reviewers: juan, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2750
2016-03-17 13:11:00 -07:00
..
account-contact-field.cjsx More sending fixes - attachments working! 2016-01-26 18:03:01 -08:00
collapsed-participants.cjsx feat(keymap): add new <KeymapHandlers /> 2015-11-06 11:47:06 -08:00
compose-button.cjsx feat(tooltip): use native tooltip style 2015-10-21 11:27:57 -07:00
composer-editor.jsx fix(quoted-text): div vs blockquote, signature cleanup #1746 2016-03-17 13:11:00 -07:00
composer-view.cjsx fix(quoted-text): div vs blockquote, signature cleanup #1746 2016-03-17 13:11:00 -07:00
expanded-participants.cjsx fix(error-handling): handle offline for link tracking & read-receipts 2016-02-24 16:06:08 -08:00
fields.cjsx feat(composer): participants collapse 2015-09-14 10:37:00 -04:00
file-upload.cjsx fix(uploads): Display icon regardless of ext capitalization 2016-03-15 09:31:22 -07:00
image-file-upload.cjsx Refactor FileUploadStore and composer attachments - WIP 2016-01-26 15:36:38 -08:00
main.cjsx fix(min-height): Reduce minimum window size to 250px. Fixes #1293 2016-02-10 12:39:13 -08:00
participants-text-field.cjsx fix(composer): fix dissapearing participant bug w/ multiple composers 2016-02-15 18:12:41 -05:00
send-action-button.cjsx feat(composer): new composer footer and icon design 2016-02-23 13:42:10 -08:00