Mailspring/internal_packages/composer/spec
Ben Gotow 9099542643 fix(quoted-text): div vs blockquote, signature cleanup #1746
Summary:
Previously we always created <blockquote class="gmail_quote"> to wrap quoted text. This is not correct.
Gmail uses blockquotes only when it wants visual indentation, and <div>s to wrap other quoted text, like forwarded
messages which are not displayed indented.

This diff updates N1 to match Gmail exactly. Note that for replies, Gmail actually nests a blockquote.gmail_quote
inside a div.gmail_quote.

I also updated signature handling because it turns out the regexp that was removing existing signatures would blow
away any and all divs until it reached a <blockquote> tag.

Test Plan: See updated specs. Manually tested by creating a thread in Google Inbox and then performing fwd and reply in both N1 and Inbox. Results match.

Reviewers: juan, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2750
2016-03-17 13:11:00 -07:00
..
collapsed-participants-spec.cjsx feat(composer): participants collapse 2015-09-14 10:37:00 -04:00
composer-view-spec.cjsx fix(quoted-text): div vs blockquote, signature cleanup #1746 2016-03-17 13:11:00 -07:00
expanded-participants-spec.cjsx fix(composer): Change state.focusedField when clicking fields—see details 2015-12-08 17:44:20 -08:00
participants-text-field-spec.cjsx fix(composer): fix dissapearing participant bug w/ multiple composers 2016-02-15 18:12:41 -05:00
quoted-text-spec.cjsx feat(send): Send and Archive 2016-01-25 14:14:09 -08:00
send-actions-spec.cjsx fix(send-action): Make dropdown trigger secondary send actions 2016-02-03 16:27:11 -08:00