mirror of
https://github.com/Foundry376/Mailspring.git
synced 2025-03-01 10:33:14 +08:00
9a01aa7bcb
Summary: This commit makes it so we /always/ catch errors thrown in the request established inside `NylasLongConnection`. Specifically, it catches an uncaught `socket hang up` error which is flooding Sentry unnecessarily (https://sentry.io/nylas/nylas-mail-old-1030/issues/213178758/). This error is thrown when the long connection is manually ended before any data was received from the request (which happens most times during search when you clear the search query). The problem was that when we end the long connection, we remove all event listeners from the request, and /then/ the error is thrown, at which point there is no error handler to catch it. The solution is simply to always have an error handler attached to the request object. This commit also adds extra error handling that seems to have been missing. Test Plan: manually check that delta connection is still working, and that error is no longer thrown when you search and then immediately clear the search Reviewers: mark, evan, spang Reviewed By: spang Differential Revision: https://phab.nylas.com/D4096 |
||
|---|---|---|
| .. | ||
| client-app | ||
| client-sync | ||
| isomorphic-core | ||
| README.md | ||
Monorepo Packages
Each folder here is designed to act as its own repository. For development convenience, they are all included here in one monorepo. This allows us to grep across multiple codebases, not use submodules, and keep a unified commit history.
We use Lerna to manage the monorepo and tie
them all together with the main nylas-mail-all/scripts/postinstall.es6 script,
which in turn, calls lerna bootstrap