Mailspring/packages/client-app
Juan Tejada 9a01aa7bcb [client-app] Prevent noisy uncaught errors when closing long connection
Summary:
This commit makes it so we /always/ catch errors thrown in the request
established inside `NylasLongConnection`. Specifically, it catches an
uncaught `socket hang up` error which is flooding Sentry unnecessarily
(https://sentry.io/nylas/nylas-mail-old-1030/issues/213178758/).

This error is thrown when the long connection is manually ended before
any data was received from the request (which happens most times during
search when you clear the search query).

The problem was that when we end the long connection, we remove all event listeners
from the request, and /then/ the error is thrown, at which point there is no error
handler to catch it. The solution is simply to always have an error handler attached to
the request object.

This commit also adds extra error handling that seems to have been missing.

Test Plan:
manually check that delta connection is still working, and that error
is no longer thrown when you search and then immediately clear the search

Reviewers: mark, evan, spang

Reviewed By: spang

Differential Revision: https://phab.nylas.com/D4096
2017-03-05 23:14:49 -08:00
..
apm
build [client-app] fix keychain issue on OSX build 2017-03-02 17:56:09 -08:00
docs
docs_src
dot-nylas
internal_packages [client-app] Report 100% of search performed events 2017-03-01 14:56:25 -08:00
keymaps
menus [client-app] Report source when reporting open times for accts window 2017-02-23 16:17:50 -08:00
script [*] move to monorepo 2017-02-16 18:46:26 -08:00
spec [client-app] Add proper IMAP search backend 2017-03-02 14:50:35 -08:00
src [client-app] Prevent noisy uncaught errors when closing long connection 2017-03-05 23:14:49 -08:00
static [client-app, client-private-plugins] Update the pending send-reminders UI 2017-03-02 09:52:30 -08:00
.babelrc [client-app] symlink in babelrc and resolve links 2017-02-21 16:08:59 -05:00
.travis.yml [client-app] update build system 2017-02-21 17:32:22 -05:00
.watchmanconfig
book.json
CHANGELOG.md [client-app] Update changelog 2017-02-28 13:19:34 -08:00
CONFIGURATION.md
CONTRIBUTING.md
ISSUE_TEMPLATE.md
LICENSE.md
package.json bump(version) 1.0.31 2017-03-02 12:10:50 -08:00
README.md

Nylas Mail - the open-source, extensible mail client

N1 Screenshot

Nylas Mail is an open-source mail client built on the modern web with Electron, React, and Flux. It is designed to be extensible, so it's easy to create new experiences and workflows around email. Want to learn more? Check out the full documentation.

Build Status Slack Invite Button

Want to help build the future of email? Nylas is hiring!

Download Nylas Mail

You can download compiled versions of Nylas Mail for Windows, Mac OS X, and Linux (.deb) from https://nylas.com/download. You can also build and run Nylas Mail (Previously N1) on Fedora. On Arch Linux, you can install n1 or n1-git from the aur.

Build A Plugin

Plugins lie at the heart of Nylas Mail and give it its powerful features. Building your own plugins allows you to integrate the app with other tools, experiment with new workflows, and more. Follow the Getting Started guide to write your first plugin in five minutes. To create your own theme, go to our Theme Starter guide.

If you would like to run the N1 source and contribute, check out our contributing guide.

Themes

The Nylas Mail user interface is styled using CSS, which means it's easy to modify and extend. Nylas Mail comes stock with a few beautiful themes, and there are many more which have been built by community developers

Bundled Themes

Community Themes

To install community themes:

  1. Download and unzip the repo
  2. In Nylas Mail, select Developer > Install a Package Manually...
  3. Navigate to where you downloaded the theme and select the root folder. The theme is copied into the ~/.nylas-mail folder for your convinence
  4. Select Change Theme... from the top level menu, and you'll see the newly installed theme. That's it!

Want to dive in more? Try creating your own theme!

Plugin List

We're working on building a plugin index that makes it super easy to add them to Nylas Mail. For now, check out the list below! (Feel free to submit a PR if you build a plugin and want it featured here.)

Bundled Plugins

Great starting points for creating your own plugins!

Community Plugins

Note these are not tested or officially supported by Nylas, but we still think they are really cool! If you find bugs with them, please open GitHub issues on their individual project pages, not the Nylas Mail (N1) repo page. Thanks!

When you install packages, they're moved to ~/.nylas-mail/packages, and Nylas Mail runs apm install on the command line to fetch dependencies listed in the package's package.json

Building the docs

Plugin SDK docs are available at https://nylas.github.io/nylas-mail/. Here's how you build them:

Until my patch gets merged, docs need to be built manually using mg's fork.

git clone git@github.com:grinich/gitbook.git

cd nylas-mail

./node_modules/.bin/gitbook alias ../gitbook latest

Then to actually build the docs:

script/grunt docs

./node_modules/.bin/gitbook --gitbook=latest build . ./_docs_output --log=debug --debug

rm -r docs_src/classes

If you want to preview the docs:

pushd ./_docs_output; python -m SimpleHTTPServer; popd

Just want to publish everything? There's a helper script that does it for you:

script/publish-docs

Configuration

You can configure Nylas Mail in a few ways—for instance, pointing it to your self-hosted instance of the sync engine or changing the interface zoom level. Learn more about how.

Feature Requests / Plugin Ideas

Have an idea for a package or a feature you'd love to see in Nylas Mail? Search for existing GitHub issues and join the conversation!