mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-11-12 04:25:31 +08:00
d1c587a01c
More spec fixes replace process.nextTick with setTimeout(fn, 0) for specs Also added an unspy in the afterEach Temporarily disable specs fix(spec): start fixing specs Summary: This is the WIP fix to our spec runner. Several tests have been completely commented out that will require substantially more work to fix. These have been added to our sprint backlog. Other tests have been fixed to update to new APIs or to deal with genuine bugs that were introduced without our knowing! The most common non-trivial change relates to observing the `NylasAPI` and `NylasAPIRequest`. We used to observe the arguments to `makeRequest`. Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do: `NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the `options` passed into the object. the `.object` property grabs the context of the spy when it was last called. Fixing these tests uncovered several concerning issues with our test runner. I spent a while tracking down why our participant-text-field-spec was failling every so often. I chose that spec because it was the first spec to likely fail, thereby requiring looking at the least number of preceding files. I tried binary searching, turning on and off, several files beforehand only to realize that the failure rate was not determined by a particular preceding test, but rather the existing and quantity of preceding tests, AND the number of console.log statements I had. There is some processor-dependent race condition going on that needs further investigation. I also discovered an issue with the file-download-spec. We were getting errors about it accessing a file, which was very suspicious given the code stubs out all fs access. This was caused due to a spec that called an async function outside ot a `waitsForPromise` block or a `waitsFor` block. The test completed, the spies were cleaned up, but the downstream async chain was still running. By the time the async chain finished the runner was already working on the next spec and the spies had been restored (causing the real fs access to run). Juan had an idea to kill the specs once one fails to prevent cascading failures. I'll implement this in the next diff update Test Plan: npm test Reviewers: juan, halla, jackie Differential Revision: https://phab.nylas.com/D3501 Disable other specs Disable more broken specs All specs turned off till passing state Use async-safe versions of spec functions Add async test spec Remove unused package code Remove canary spec
300 lines
11 KiB
JavaScript
300 lines
11 KiB
JavaScript
/* eslint quote-props: 0 */
|
|
import Thread from '../../src/flux/models/thread';
|
|
import TestModel from '../fixtures/db-test-model';
|
|
import ModelQuery from '../../src/flux/models/query';
|
|
import DatabaseStore from '../../src/flux/stores/database-store';
|
|
|
|
const testMatchers = {'id': 'b'};
|
|
|
|
xdescribe("DatabaseStore", function DatabaseStoreSpecs() {
|
|
beforeEach(() => {
|
|
TestModel.configureBasic();
|
|
|
|
DatabaseStore._atomicallyQueue = undefined;
|
|
DatabaseStore._mutationQueue = undefined;
|
|
DatabaseStore._inTransaction = false;
|
|
|
|
spyOn(ModelQuery.prototype, 'where').andCallThrough();
|
|
spyOn(DatabaseStore, 'accumulateAndTrigger').andCallFake(() => Promise.resolve());
|
|
|
|
this.performed = [];
|
|
|
|
// Note: We spy on _query and test all of the convenience methods that sit above
|
|
// it. None of these tests evaluate whether _query works!
|
|
jasmine.unspy(DatabaseStore, "_query");
|
|
spyOn(DatabaseStore, "_query").andCallFake((query, values = []) => {
|
|
this.performed.push({query, values});
|
|
return Promise.resolve([]);
|
|
});
|
|
});
|
|
|
|
describe("find", () =>
|
|
it("should return a ModelQuery for retrieving a single item by Id", () => {
|
|
const q = DatabaseStore.find(TestModel, "4");
|
|
expect(q.sql()).toBe("SELECT `TestModel`.`data` FROM `TestModel` WHERE `TestModel`.`id` = '4' LIMIT 1");
|
|
})
|
|
|
|
);
|
|
|
|
describe("findBy", () => {
|
|
it("should pass the provided predicates on to the ModelQuery", () => {
|
|
DatabaseStore.findBy(TestModel, testMatchers);
|
|
expect(ModelQuery.prototype.where).toHaveBeenCalledWith(testMatchers);
|
|
});
|
|
|
|
it("should return a ModelQuery ready to be executed", () => {
|
|
const q = DatabaseStore.findBy(TestModel, testMatchers);
|
|
expect(q.sql()).toBe("SELECT `TestModel`.`data` FROM `TestModel` WHERE `TestModel`.`id` = 'b' LIMIT 1");
|
|
});
|
|
});
|
|
|
|
describe("findAll", () => {
|
|
it("should pass the provided predicates on to the ModelQuery", () => {
|
|
DatabaseStore.findAll(TestModel, testMatchers);
|
|
expect(ModelQuery.prototype.where).toHaveBeenCalledWith(testMatchers);
|
|
});
|
|
|
|
it("should return a ModelQuery ready to be executed", () => {
|
|
const q = DatabaseStore.findAll(TestModel, testMatchers);
|
|
expect(q.sql()).toBe("SELECT `TestModel`.`data` FROM `TestModel` WHERE `TestModel`.`id` = 'b' ");
|
|
});
|
|
});
|
|
|
|
describe("modelify", () => {
|
|
beforeEach(() => {
|
|
this.models = [
|
|
new Thread({clientId: 'local-A'}),
|
|
new Thread({clientId: 'local-B'}),
|
|
new Thread({clientId: 'local-C'}),
|
|
new Thread({clientId: 'local-D', serverId: 'SERVER:D'}),
|
|
new Thread({clientId: 'local-E', serverId: 'SERVER:E'}),
|
|
new Thread({clientId: 'local-F', serverId: 'SERVER:F'}),
|
|
new Thread({clientId: 'local-G', serverId: 'SERVER:G'}),
|
|
];
|
|
// Actually returns correct sets for queries, since matchers can evaluate
|
|
// themselves against models in memory
|
|
spyOn(DatabaseStore, 'run').andCallFake(query => {
|
|
const results = this.models.filter(model =>
|
|
query._matchers.every(matcher => matcher.evaluate(model))
|
|
);
|
|
return Promise.resolve(results);
|
|
});
|
|
});
|
|
|
|
describe("when given an array or input that is not an array", () =>
|
|
it("resolves immediately with an empty array", () =>
|
|
waitsForPromise(() => {
|
|
return DatabaseStore.modelify(Thread, null).then(output => {
|
|
expect(output).toEqual([]);
|
|
});
|
|
})
|
|
)
|
|
);
|
|
|
|
describe("when given an array of mixed IDs, clientIDs, and models", () =>
|
|
it("resolves with an array of models", () => {
|
|
const input = ['SERVER:F', 'local-B', 'local-C', 'SERVER:D', this.models[6]];
|
|
const expectedOutput = [this.models[5], this.models[1], this.models[2], this.models[3], this.models[6]];
|
|
return waitsForPromise(() => {
|
|
return DatabaseStore.modelify(Thread, input).then(output => {
|
|
expect(output).toEqual(expectedOutput);
|
|
});
|
|
});
|
|
})
|
|
|
|
);
|
|
|
|
describe("when the input is only IDs", () =>
|
|
it("resolves with an array of models", () => {
|
|
const input = ['SERVER:D', 'SERVER:F', 'SERVER:G'];
|
|
const expectedOutput = [this.models[3], this.models[5], this.models[6]];
|
|
return waitsForPromise(() => {
|
|
return DatabaseStore.modelify(Thread, input).then(output => {
|
|
expect(output).toEqual(expectedOutput);
|
|
});
|
|
});
|
|
})
|
|
|
|
);
|
|
|
|
describe("when the input is only clientIDs", () =>
|
|
it("resolves with an array of models", () => {
|
|
const input = ['local-A', 'local-B', 'local-C', 'local-D'];
|
|
const expectedOutput = [this.models[0], this.models[1], this.models[2], this.models[3]];
|
|
return waitsForPromise(() => {
|
|
return DatabaseStore.modelify(Thread, input).then(output => {
|
|
expect(output).toEqual(expectedOutput);
|
|
});
|
|
});
|
|
})
|
|
|
|
);
|
|
|
|
describe("when the input is all models", () =>
|
|
it("resolves with an array of models", () => {
|
|
const input = [this.models[0], this.models[1], this.models[2], this.models[3]];
|
|
const expectedOutput = [this.models[0], this.models[1], this.models[2], this.models[3]];
|
|
return waitsForPromise(() => {
|
|
return DatabaseStore.modelify(Thread, input).then(output => {
|
|
expect(output).toEqual(expectedOutput);
|
|
});
|
|
});
|
|
})
|
|
|
|
);
|
|
});
|
|
|
|
describe("count", () => {
|
|
it("should pass the provided predicates on to the ModelQuery", () => {
|
|
DatabaseStore.findAll(TestModel, testMatchers);
|
|
expect(ModelQuery.prototype.where).toHaveBeenCalledWith(testMatchers);
|
|
});
|
|
|
|
it("should return a ModelQuery configured for COUNT ready to be executed", () => {
|
|
const q = DatabaseStore.findAll(TestModel, testMatchers);
|
|
expect(q.sql()).toBe("SELECT `TestModel`.`data` FROM `TestModel` WHERE `TestModel`.`id` = 'b' ");
|
|
});
|
|
});
|
|
|
|
describe("inTransaction", () => {
|
|
it("calls the provided function inside an exclusive transaction", () =>
|
|
waitsForPromise(() => {
|
|
return DatabaseStore.inTransaction(() => {
|
|
return DatabaseStore._query("TEST");
|
|
}).then(() => {
|
|
expect(this.performed.length).toBe(3);
|
|
expect(this.performed[0].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[1].query).toBe("TEST");
|
|
expect(this.performed[2].query).toBe("COMMIT");
|
|
});
|
|
})
|
|
|
|
);
|
|
|
|
it("preserves resolved values", () =>
|
|
waitsForPromise(() => {
|
|
return DatabaseStore.inTransaction(() => {
|
|
DatabaseStore._query("TEST");
|
|
return Promise.resolve("myValue");
|
|
}).then(myValue => {
|
|
expect(myValue).toBe("myValue");
|
|
});
|
|
})
|
|
|
|
);
|
|
|
|
it("always fires a COMMIT, even if the body function fails", () =>
|
|
waitsForPromise(() => {
|
|
return DatabaseStore.inTransaction(() => {
|
|
throw new Error("BOOO");
|
|
}).catch(() => {
|
|
expect(this.performed.length).toBe(2);
|
|
expect(this.performed[0].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[1].query).toBe("COMMIT");
|
|
});
|
|
})
|
|
|
|
);
|
|
|
|
it("can be called multiple times and get queued", () =>
|
|
waitsForPromise(() => {
|
|
return Promise.all([
|
|
DatabaseStore.inTransaction(() => Promise.resolve()),
|
|
DatabaseStore.inTransaction(() => Promise.resolve()),
|
|
DatabaseStore.inTransaction(() => Promise.resolve()),
|
|
]).then(() => {
|
|
expect(this.performed.length).toBe(6);
|
|
expect(this.performed[0].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[1].query).toBe("COMMIT");
|
|
expect(this.performed[2].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[3].query).toBe("COMMIT");
|
|
expect(this.performed[4].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[5].query).toBe("COMMIT");
|
|
});
|
|
})
|
|
|
|
);
|
|
|
|
it("carries on if one of them fails, but still calls the COMMIT for the failed block", () => {
|
|
let caughtError = false;
|
|
DatabaseStore.inTransaction(() => DatabaseStore._query("ONE"));
|
|
DatabaseStore.inTransaction(() => { throw new Error("fail"); }).catch(() => { caughtError = true });
|
|
DatabaseStore.inTransaction(() => DatabaseStore._query("THREE"));
|
|
advanceClock(100);
|
|
expect(this.performed.length).toBe(8);
|
|
expect(this.performed[0].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[1].query).toBe("ONE");
|
|
expect(this.performed[2].query).toBe("COMMIT");
|
|
expect(this.performed[3].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[4].query).toBe("COMMIT");
|
|
expect(this.performed[5].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[6].query).toBe("THREE");
|
|
expect(this.performed[7].query).toBe("COMMIT");
|
|
expect(caughtError).toBe(true);
|
|
});
|
|
|
|
it("is actually running in series and blocks on never-finishing specs", () => {
|
|
let resolver = null;
|
|
DatabaseStore.inTransaction(() => Promise.resolve());
|
|
advanceClock(100);
|
|
expect(this.performed.length).toBe(2);
|
|
expect(this.performed[0].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[1].query).toBe("COMMIT");
|
|
DatabaseStore.inTransaction(() => new Promise((resolve) => { resolver = resolve }));
|
|
advanceClock(100);
|
|
let blockedPromiseDone = false;
|
|
DatabaseStore.inTransaction(() => Promise.resolve()).then(() => {
|
|
blockedPromiseDone = true;
|
|
});
|
|
advanceClock(100);
|
|
expect(this.performed.length).toBe(3);
|
|
expect(this.performed[2].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(blockedPromiseDone).toBe(false);
|
|
|
|
// Now that we've made our assertion about blocking, we need to clean up
|
|
// our test and actually resolve that blocked promise now, otherwise
|
|
// remaining tests won't run properly.
|
|
advanceClock(100);
|
|
resolver();
|
|
advanceClock(100);
|
|
expect(blockedPromiseDone).toBe(true);
|
|
return advanceClock(100);
|
|
});
|
|
|
|
it("can be called multiple times and preserve return values", () =>
|
|
waitsForPromise(() => {
|
|
let v1 = null;
|
|
let v2 = null;
|
|
let v3 = null;
|
|
return Promise.all([
|
|
DatabaseStore.inTransaction(() => Promise.resolve("a")).then(val => { v1 = val }),
|
|
DatabaseStore.inTransaction(() => Promise.resolve("b")).then(val => { v2 = val }),
|
|
DatabaseStore.inTransaction(() => Promise.resolve("c")).then(val => { v3 = val }),
|
|
]).then(() => {
|
|
expect(v1).toBe("a");
|
|
expect(v2).toBe("b");
|
|
expect(v3).toBe("c");
|
|
});
|
|
})
|
|
|
|
);
|
|
|
|
it("can be called multiple times and get queued", () =>
|
|
waitsForPromise(() => {
|
|
return DatabaseStore.inTransaction(() => Promise.resolve())
|
|
.then(() => DatabaseStore.inTransaction(() => Promise.resolve()))
|
|
.then(() => DatabaseStore.inTransaction(() => Promise.resolve()))
|
|
.then(() => {
|
|
expect(this.performed.length).toBe(6);
|
|
expect(this.performed[0].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[1].query).toBe("COMMIT");
|
|
expect(this.performed[2].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[3].query).toBe("COMMIT");
|
|
expect(this.performed[4].query).toBe("BEGIN IMMEDIATE TRANSACTION");
|
|
expect(this.performed[5].query).toBe("COMMIT");
|
|
});
|
|
})
|
|
|
|
);
|
|
});
|
|
});
|