Summary: This diff contains a few major changes: 1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario: - View thread with draft, edit draft - Move to another thread - Move back to thread with draft - Move to another thread. Notice that one or more messages from thread with draft are still there. There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great. 2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here: - In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI. - Previously, when you added a contact to To/CC/BCC, this happened: <input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state. To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source! This diff includes a few minor fixes as well: 1. Draft.state is gone—use Message.object = draft instead 2. String model attributes should never be null 3. Pre-send checks that can cancel draft send 4. Put the entire curl history and task queue into feedback reports 5. Cache localIds for extra speed 6. Move us up to latest React Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet Reviewers: evan Reviewed By: evan Differential Revision: https://review.inboxapp.com/D1125
5.9 KiB
Create Your First Package
This tutorial will guide you though creating a simple command that replaces the selected text with ascii art. When you run our new command with the word "cool" selected, it will be replaced with:
___
/\_ \
___ ___ ___\//\ \
/'___\ / __`\ / __`\\ \ \
/\ \__//\ \L\ \/\ \L\ \\_\ \_
\ \____\ \____/\ \____//\____\
\/____/\/___/ \/___/ \/____/
The final package can be viewed at https://github.com/atom/ascii-art.
To begin, press cmd-shift-P
to bring up the Command
Palette. Type "generate package" and
select the "Package Generator: Generate Package" command. Now we need to name
the package. Try to avoid naming your package with the atom- prefix, for
example we are going to call this package ascii-art.
Atom will open a new window with the contents of our new ascii-art package
displayed in the Tree View. Because this window is opened after the package
is created, the ASCII Art package will be loaded and available in our new
window. To verify this, toggle the Command Palette (cmd-shift-P
) and type
"ASCII Art". You'll see a new ASCII Art: Toggle
command. When triggered, this
command displays a default message.
Now let's edit the package files to make our ASCII Art package do something
interesting. Since this package doesn't need any UI, we can remove all
view-related code. Start by opening up lib/ascii-art.coffee. Remove all view
code, so the module.exports
section looks like this:
module.exports =
activate: ->
Create a Command
Now let's add a command. We recommend that you namespace your commands with the
package name followed by a :
, so we'll call our command ascii-art:convert
.
Register the command in lib/ascii-art.coffee:
module.exports =
activate: ->
atom.commands.add 'atom-workspace', "ascii-art:convert", => @convert()
convert: ->
# This assumes the active pane item is an editor
editor = atom.workspace.getActivePaneItem()
editor.insertText('Hello, World!')
The atom.commands.add
method takes a selector, command name, and a callback.
The callback executes when the command is triggered on an element matching the
selector. In this case, when the command is triggered the callback will call the
convert
method and insert 'Hello, World!'.
Reload the Package
Before we can trigger ascii-art:convert
, we need to load the latest code for
our package by reloading the window. Run the command window:reload
from the
command palette or by pressing ctrl-alt-cmd-l
.
Trigger the Command
Now open the command panel and search for the ascii-art:convert
command. But
it's not there! To fix this, open package.json and find the property called
activationCommands
. Activation Events speed up load time by allowing Atom to
delay a package's activation until it's needed. So remove the existing command
and add ascii-art:convert
to the activationCommands
array:
"activationCommands": ["ascii-art:convert"],
First, reload the window by running the command window:reload
. Now when you
run the ascii-art:convert
command it will output 'Hello, World!'
Add a Key Binding
Now let's add a key binding to trigger the ascii-art:convert
command. Open
keymaps/ascii-art.cson and add a key binding linking ctrl-alt-a
to the
ascii-art:convert
command. You can delete the pre-existing key binding since
you don't need it anymore. When finished, the file will have this:
'atom-text-editor':
'ctrl-alt-a': 'ascii-art:convert'
Notice atom-text-editor
on the first line. Just like CSS, keymap selectors
scope key bindings so they only apply to specific elements. In this case, our
binding is only active for elements matching the atom-text-editor
selector. If
the Tree View has focus, pressing ctrl-alt-a
won't trigger the
ascii-art:convert
command. But if the editor has focus, the
ascii-art:convert
method will be triggered. More information on key bindings
can be found in the keymaps documentation.
Now reload the window and verify that the key binding works! You can also verify that it doesn't work when the Tree View is focused.
Add the ASCII Art
Now we need to convert the selected text to ASCII art. To do this we will use the figlet node module from npm. Open package.json and add the latest version of figlet to the dependencies:
"dependencies": {
"figlet": "1.0.8"
}
After saving the file, run the command 'update-package-dependencies:update' from the Command Palette. This will install the package's node module dependencies, only figlet in this case. You will need to run 'update-package-dependencies:update' whenever you update the dependencies field in your package.json file.
Now require the figlet node module in lib/ascii-art.coffee and instead of inserting 'Hello, World!' convert the selected text to ASCII art.
convert: ->
# This assumes the active pane item is an editor
editor = atom.workspace.getActivePaneItem()
selection = editor.getLastSelection()
figlet = require 'figlet'
figlet selection.getText(), {font: "Larry 3D 2"}, (error, asciiArt) ->
if error
console.error(error)
else
selection.insertText("\n#{asciiArt}\n")
Select some text in an editor window and hit ctrl-alt-a
. 🎉 You're now an
ASCII art professional!
Further reading
-
Writing specs for your package
-
Creating a package guide for more information on the mechanics of packages
-
Publishing a package guide for more information on publishing your package to atom.io