mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-11-11 01:54:40 +08:00
b4434f6617
Summary:
- Removes controlled focus in the composer!
- No React components ever perfom focus in lifecycle methods. Never again.
- A new `Utils.schedule({action, after, timeout})` helper makes it easy to say "setState or load draft, etc. and then focus"
- The DraftStore issues a focusDraft action after creating a draft, which causes the MessageList to focus and scroll to the desired composer, which itself decides which field to focus.
- The MessageList never focuses anything automatically.
- Refactors ComposerView apart — ComposerHeader handles all top fields, DraftSessionContainer handles draft session initialization and exposes props to ComposerView
- ComposerHeader now uses a KeyCommandRegion (with focusIn and focusOut) to do the expanding and collapsing of the participants fields. May rename that container very soon.
- Removes all CommandRegistry handling of tab and shift-tab. Unless you preventDefault, the browser does it's thing.
- Removes all tabIndexes greater than 1. This is an anti-pattern—assigning everything a tabIndex of 0 tells the browser to move between them based on their order in the DOM, and is almost always what you want.
- Adds "TabGroupRegion" which allows you to create a tab/shift-tabbing group, (so tabbing does not leave the active composer). Can't believe this isn't a browser feature.
Todos:
- Occasionally, clicking out of the composer contenteditable requires two clicks. This is because atomicEdit is restoring selection within the contenteditable and breaking blur.
- Because the ComposerView does not render until it has a draft, we're back to it being white in popout composers for a brief moment. We will fix this another way - all the "return unless draft" statements were untenable.
- Clicking a row in the thread list no longer shifts focus to the message list and focuses the last draft. This will be restored soon.
Test Plan: Broken
Reviewers: juan, evan
Reviewed By: juan, evan
Differential Revision: https://phab.nylas.com/D2814
|
||
|---|---|---|
| .. | ||
| components | ||
| extensions | ||
| fixtures | ||
| models | ||
| services | ||
| stores | ||
| tasks | ||
| action-bridge-spec.coffee | ||
| auto-update-manager-spec.coffee | ||
| buffered-process-spec.coffee | ||
| clipboard-spec.coffee | ||
| component-registry-spec.coffee | ||
| database-object-registry-spec.coffee | ||
| date-utils-spec.es6 | ||
| dom-utils-spec.coffee | ||
| extension-registry-spec.coffee | ||
| jasmine-helper.coffee | ||
| jasmine-jquery.js | ||
| jasmine.js | ||
| launch-services-spec.coffee | ||
| list-selection-spec.coffee | ||
| mail-rules-processor-spec.coffee | ||
| mailbox-perspective-spec.es6 | ||
| menu-manager-spec.coffee | ||
| module-cache-spec.coffee | ||
| n1-spec-reporter.coffee | ||
| nylas-api-spec.coffee | ||
| nylas-env-spec.coffee | ||
| nylas-protocol-handler-spec.coffee | ||
| nylas-test-utils.coffee | ||
| package-manager-spec.coffee | ||
| package-spec.coffee | ||
| quoted-html-transformer-spec.coffee | ||
| quoted-plain-text-transformer-spec.coffee | ||
| spec-bootstrap.coffee | ||
| spec-helper-platform.coffee | ||
| spec-helper.coffee | ||
| spec-suite.coffee | ||
| spellchecker-spec.coffee | ||
| style-manager-spec.coffee | ||
| styles-element-spec.coffee | ||
| task-factory-spec.es6 | ||
| theme-manager-spec.coffee | ||
| time-override.coffee | ||
| time-reporter.coffee | ||
| undo-manager-spec.coffee | ||
| utils-spec.coffee | ||