mirror of
https://github.com/gravitl/netmaker.git
synced 2024-09-20 15:26:04 +08:00
remove unnecessary test
This commit is contained in:
parent
61e5ae9d02
commit
1b17bcd087
|
@ -316,13 +316,13 @@ func TestValidateDNSUpdate(t *testing.T) {
|
|||
assert.NotNil(t, err)
|
||||
assert.Contains(t, err.Error(), "Field validation for 'Network' failed on the 'network_exists' tag")
|
||||
})
|
||||
t.Run("EmptyAddress", func(t *testing.T) {
|
||||
//this can't actually happen as change.Address is populated if is blank
|
||||
change := models.DNSEntry{"", "", "myhost", "skynet"}
|
||||
err := logic.ValidateDNSUpdate(change, entry)
|
||||
assert.NotNil(t, err)
|
||||
assert.Contains(t, err.Error(), "Field validation for 'Address' failed on the 'required' tag")
|
||||
})
|
||||
// t.Run("EmptyAddress", func(t *testing.T) {
|
||||
// //this can't actually happen as change.Address is populated if is blank
|
||||
// change := models.DNSEntry{"", "", "myhost", "skynet"}
|
||||
// err := logic.ValidateDNSUpdate(change, entry)
|
||||
// assert.NotNil(t, err)
|
||||
// assert.Contains(t, err.Error(), "Field validation for 'Address' failed on the 'required' tag")
|
||||
// })
|
||||
t.Run("BadAddress", func(t *testing.T) {
|
||||
change := models.DNSEntry{"10.0.256.1", "", "myhost", "skynet"}
|
||||
err := logic.ValidateDNSUpdate(change, entry)
|
||||
|
|
Loading…
Reference in a new issue