Keep setup cell open on error (#1718)

This commit is contained in:
Jonatan Kłosko 2023-02-21 13:17:54 +01:00 committed by GitHub
parent 08391f511c
commit 7cac0557b9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions

View file

@ -131,7 +131,7 @@ solely client-side operations.
[data-el-session]
[data-el-cell][data-type="setup"]:not(
[data-eval-validity="fresh"]:not([data-js-empty])
):not([data-js-changed]):not([data-js-focused])
):not([data-eval-errored]):not([data-js-changed]):not([data-js-focused])
[data-el-editor-box] {
@apply h-0 overflow-hidden;
}
@ -144,6 +144,9 @@ solely client-side operations.
[data-js-empty]
)
[data-el-info-box],
[data-el-session]
[data-el-cell][data-type="setup"][data-eval-errored]
[data-el-info-box],
[data-el-session]
[data-el-cell][data-type="setup"][data-js-changed]
[data-el-info-box] {

View file

@ -15,6 +15,7 @@ defmodule LivebookWeb.SessionLive.CellComponent do
data-session-path={Routes.session_path(@socket, :page, @session_id)}
data-evaluation-digest={get_in(@cell_view, [:eval, :evaluation_digest])}
data-eval-validity={get_in(@cell_view, [:eval, :validity])}
data-eval-errored={get_in(@cell_view, [:eval, :errored])}
data-js-empty={empty?(@cell_view.source_view)}
data-smart-cell-js-view-ref={smart_cell_js_view_ref(@cell_view)}
data-allowed-uri-schemes={Enum.join(@allowed_uri_schemes, ",")}