Show app URLs as relative (#1835)

This commit is contained in:
Jonatan Kłosko 2023-03-28 17:41:22 +01:00 committed by GitHub
parent 6e5a0c3d29
commit dbab38a763
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 4 deletions

View file

@ -80,6 +80,10 @@ defmodule LivebookWeb do
endpoint: LivebookWeb.Endpoint, endpoint: LivebookWeb.Endpoint,
router: LivebookWeb.Router, router: LivebookWeb.Router,
statics: LivebookWeb.static_paths() statics: LivebookWeb.static_paths()
# We don't know the hostname Livebook runs on, so we don't use
# absolute URL helpers
import Phoenix.VerifiedRoutes, only: :sigils
end end
end end

View file

@ -89,8 +89,8 @@ defmodule LivebookWeb.AppsLive do
<div class="flex-1 grow-[2]"> <div class="flex-1 grow-[2]">
<.labeled_text label="URL"> <.labeled_text label="URL">
<%= if @session.app_info.registered do %> <%= if @session.app_info.registered do %>
<a href={url(~p"/apps/#{@session.app_info.slug}")} target="_blank"> <a href={~p"/apps/#{@session.app_info.slug}"} target="_blank">
<%= url(~p"/apps/#{@session.app_info.slug}") %> <%= ~p"/apps/#{@session.app_info.slug}" %>
</a> </a>
<% else %> <% else %>
- -

View file

@ -112,8 +112,8 @@ defmodule LivebookWeb.SessionLive.AppInfoComponent do
</.labeled_text> </.labeled_text>
<.labeled_text label="URL" one_line> <.labeled_text label="URL" one_line>
<%= if app.registered do %> <%= if app.registered do %>
<a href={url(~p"/apps/#{app.settings.slug}")} target="_blank"> <a href={~p"/apps/#{app.settings.slug}"} target="_blank">
<%= url(~p"/apps/#{app.settings.slug}") %> <%= ~p"/apps/#{app.settings.slug}" %>
</a> </a>
<% else %> <% else %>
- -