livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-01-19 21:38:13 +08:00
Code Issues Projects Releases Packages Wiki Activity

Improve error message when deploying notebooks without settings (#2008)

Browse source
This commit is contained in:
ByeongUk Choi 2023-06-25 16:44:36 +09:00 committed by GitHub
parent 05d691d407
commit ebab482b7e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/livebook/apps.ex
View file

@ -188,7 +188,9 @@ defmodule Livebook.Apps do
warnings = Enum.map(warnings, &("Import: " <> &1))
deploy(notebook, warnings: warnings)
else
Logger.warning("Skipping app deployment at #{path} due to invalid settings")
Logger.warning(
"Skipping app deployment at #{path}. The deployment settings are missing or invalid. Please configure them under the notebook deploy panel."
)
end
end

3
test/livebook/apps_test.exs
View file

@ -49,7 +49,8 @@ defmodule Livebook.AppsTest do
assert capture_log(fn ->
Livebook.Apps.deploy_apps_in_dir(tmp_dir)
end) =~ "Skipping app deployment at #{app_path} due to invalid settings"
end) =~
"Skipping app deployment at #{app_path}. The deployment settings are missing or invalid. Please configure them under the notebook deploy panel."
end
@tag :tmp_dir