livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-11-11 22:51:43 +08:00
Code Issues Projects Releases Packages Wiki Activity

Do not set XLA_TARGET when using Livebook CUDA-based images (#2755)

Browse source
This commit is contained in:
Jonatan Kłosko 2024-08-19 16:14:52 +02:00
parent 1ac585c9e1
commit fbb387e882
2 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/livebook/config.ex
View file

@ -65,11 +65,7 @@ defmodule Livebook.Config do
[ [
%{tag: version, name: "Livebook", env: []}, %{tag: version, name: "Livebook", env: []},
%{ %{tag: "#{version}-cuda12", name: "Livebook + CUDA 12", env: []}
tag: "#{version}-cuda12",
name: "Livebook + CUDA 12",
env: [{"XLA_TARGET", "cuda120"}]
}
] ]
end end

5
test/livebook/hubs/dockerfile_test.exs
View file

@ -174,8 +174,6 @@ defmodule Livebook.Hubs.DockerfileTest do
assert dockerfile =~ """ assert dockerfile =~ """
FROM ghcr.io/livebook-dev/livebook:#{@version}-cuda12 FROM ghcr.io/livebook-dev/livebook:#{@version}-cuda12
ENV XLA_TARGET "cuda120"
""" """
end end
@ -251,10 +249,9 @@ defmodule Livebook.Hubs.DockerfileTest do
hub = team_hub() hub = team_hub()
agent_key = Livebook.Factory.build(:agent_key) agent_key = Livebook.Factory.build(:agent_key)
%{image: image, env: env} = Dockerfile.online_docker_info(config, hub, agent_key) %{image: image, env: _env} = Dockerfile.online_docker_info(config, hub, agent_key)
assert image == "ghcr.io/livebook-dev/livebook:#{@version}-cuda12" assert image == "ghcr.io/livebook-dev/livebook:#{@version}-cuda12"
assert {"XLA_TARGET", "cuda120"} in env
end end
test "deploying with auto cluster setup" do test "deploying with auto cluster setup" do