livebook-dev/livebook
1
1
Fork 0
mirror of https://github.com/livebook-dev/livebook.git synced 2025-10-08 20:46:16 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix error on back after closing session (#769)

Browse source 
* Fix error on back after closing session

Clicking the browsers back button after closing a session
resulted in an error since it was trying to close an already closed notebook

* Overwrite back history on section delete
This commit is contained in:
Kevin 2021-12-08 13:17:50 +01:00 • committed by GitHub
parent 3f86af051c
commit feb0ac214e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/livebook_web/live/home_live/close_session_component.ex
View file

@ -30,6 +30,6 @@ defmodule LivebookWeb.HomeLive.CloseSessionComponent do
@impl true @impl true
def handle_event("close", %{}, socket) do def handle_event("close", %{}, socket) do
Livebook.Session.close(socket.assigns.session.pid) Livebook.Session.close(socket.assigns.session.pid)
{:noreply, push_patch(socket, to: socket.assigns.return_to)} {:noreply, push_patch(socket, to: socket.assigns.return_to, replace: true)}
end end
end end

2
lib/livebook_web/live/session_live/delete_section_component.ex
View file

@ -44,6 +44,6 @@ defmodule LivebookWeb.SessionLive.DeleteSectionComponent do
delete_cells? delete_cells?
) )
{:noreply, push_patch(socket, to: socket.assigns.return_to)} {:noreply, push_patch(socket, to: socket.assigns.return_to, replace: true)}
end end
end end