scinote-eln/scinote-web
1
1
Fork 0
mirror of https://github.com/scinote-eln/scinote-web.git synced 2025-11-11 08:51:32 +08:00
Code Issues Projects Releases Packages Wiki Activity

Applying hound suggestions [SCI-9016]

Browse source
This commit is contained in:
Ivan Kljun 2023-09-05 13:39:21 +02:00
parent 86e2cfe747
commit a6abfc7e31
4 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/assets/stylesheets/protocols/protocol.scss
View file

@ -129,11 +129,11 @@
min-height: 36px; min-height: 36px;
.authors-list { .authors-list {
position: relative; font-weight: bold;
max-width: calc(100% - 90px);
line-height: 32px; line-height: 32px;
margin-left: 8px; margin-left: 8px;
font-weight: bold; max-width: calc(100% - 90px);
position: relative;
} }
* { * {

2
app/assets/stylesheets/shared/inline_edit.scss
View file

@ -5,7 +5,7 @@
cursor: url("/images/icon_small/edit.svg") 0 16, auto; cursor: url("/images/icon_small/edit.svg") 0 16, auto;
} }
.inline-edit-placeholder:empty:before { .inline-edit-placeholder:empty::before {
content: attr(placeholder); content: attr(placeholder);
display: block; display: block;
} }

1
app/assets/stylesheets/steps/step.scss
View file

@ -221,7 +221,6 @@
border-radius: 4px; border-radius: 4px;
display: flex; display: flex;
min-height: 40px; min-height: 40px;
// overflow: hidden;
position: relative; position: relative;
&.editing-name { &.editing-name {

4
app/javascript/vue/shared/inline_edit.vue
View file

@ -91,10 +91,10 @@
}, },
computed: { computed: {
isBlank() { isBlank() {
return this.newValue.length === 0 return this.newValue.length === 0;
}, },
isContentDefault() { isContentDefault() {
return this.$refs ? this.$refs.input.innerText === this.defaultValue : false; return this.newValue === this.defaultValue;
}, },
error() { error() {
if(!this.allowBlank && this.isBlank) { if(!this.allowBlank && this.isBlank) {