Commit graph

1508 commits

Author SHA1 Message Date
mbilker fbcab54642 fix(travis): readd whitespace, reorder according to build Travis build process
Found the order at https://docs.travis-ci.com/user/customizing-the-build/.

In nylas/N1@989f38ca77 the entire build script
was merged from Evan Morikawa, which reordered the whole Travis build script.
athis commit reorders the to have the Travis build environment config at the
beginning of the script and the build process at the end and the Travis
secure variables at the end of the script.
2015-12-10 11:59:32 -05:00
Evan Morikawa 4014b4e187 feat(spec): add config dir to integration specs
Summary:
- You can now pass `--config-dir-path=/some/custom/path` to `./N1.sh`
- `main.coffee` cleaned up a bit. A lot of unused params from legacy Atom
  stuff were still being used
- Integration specs now set the config dir before booting.
- New spec to check for the autoupdater in the app and make sure it's
  pointing at the right place.

Test Plan: script/grunt run-integration-tests

Reviewers: juan, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2331
2015-12-10 10:52:20 -05:00
Michael Grinich 7000a1c71b Merge pull request #652 from sriraman/patch-1
Update README.md
2015-12-09 23:53:21 -08:00
sriraman 74a7e09066 Update README.md
Fix typo
2015-12-10 12:33:10 +05:30
Ben Gotow 1904c6f80b perf(travis): Fewer mac builds—Travis has fixed OS X bandwidth 2015-12-09 19:38:44 -08:00
Ben Gotow fe5d78cc51 fix(downloads): Download.run must resolve with self 2015-12-09 17:02:53 -08:00
Drew Regitsky a3e986d94a fix(quickschedule): Several UI fixes
Summary:
Fixes a number of smaller UI issues. Fixes T6173, T6207
Full list of changes:
 - Ensure time slots / days display in order
 - Allow time blocks of any size to be set on half hour intervals
 - Don't reset calendar when changing event length
 - Expand calendar on window resize
 - Change window title from "Electron"
 - Add delete button to cancel individual calendar events
 - Move event details box to the left side
 - Prevent addition of duplicate time slots

Test Plan: manual

Reviewers: bengotow

Reviewed By: bengotow

Maniphest Tasks: T6173, T6207

Differential Revision: https://phab.nylas.com/D2333
2015-12-09 16:41:30 -08:00
Ben Gotow 2dc43d141b fix(menu): Toggle Menu Bar doesn't do anything #606 2015-12-09 16:27:47 -08:00
Ben Gotow 193bd0c06e Merge pull request #628 from mbilker/task-helper-undefined-process-env
Replace function accessor with property accessor in Grunt's task-helper script
2015-12-09 16:02:09 -08:00
Ben Gotow 9ba157aadf Merge pull request #629 from mbilker/classnames-require-case-sensitive
Require `classNames` throws error under Linux
2015-12-09 15:57:40 -08:00
Ben Gotow 1a62cd8c59 bump(changelog): Update for 0.3.29 2015-12-09 15:47:51 -08:00
Ben Gotow 838646b7e4 fix(spinner): Improve loading indicator style / tweening 2015-12-09 15:47:51 -08:00
Evan Morikawa 7d56b6828a fix(spellcheck): add test for null navigator.language 2015-12-09 18:32:54 -05:00
Evan Morikawa cbd4060edf bump(internal): update submodule reference 2015-12-09 18:14:01 -05:00
Evan Morikawa 9af40833ac fix(spellcheck): check for existing languages and add tests 2015-12-09 18:10:55 -05:00
Evan Morikawa e18a272803 fix(language): default to english if language doesn't exist 2015-12-09 16:47:49 -05:00
Ben Gotow bdbeb31049 bump(electron): 0.35.4 2015-12-09 12:29:42 -08:00
Ben Gotow e19a69c4a8 polish(quick-schedule): Use calendar icon in the composer 2015-12-09 10:55:08 -08:00
Ben Gotow c993a1f51a bump(version): 0.3.29 2015-12-08 17:56:58 -08:00
Ben Gotow af75a5170c fix(translate): Use an icon for the translate button 2015-12-08 17:56:42 -08:00
Ben Gotow ee78090ce0 fix(composer): Change state.focusedField when clicking fields—see details
Clicking participant fields to type in them did not cause state.focusedField to change, because no onFocus events were bound to the ParticipantTextFields. Since setState was not called, the focus would appear to change but revert as soon as you touched state.

This diff also renames `onChangeEnabledFields` to `onAdjustEnabledFields` making it more clear that unlike the other handlers, it does not take a new value, it takes a set of changes. I also noticed that we /always/ focus fields when showing them, so I removed the separate focus param from it and made it adjust focus at the composer-view level only.

I also consolidated everywhere that touches `state.focusedField` so that we can keep the `_lastFocusedParticipantField` value in sync with it more easily.
2015-12-08 17:44:20 -08:00
Ben Gotow 1bc10cfbbb fix(auth): Log first account creation 2015-12-08 17:05:59 -08:00
mbilker a022718684 fix(require): require classNames throws error under Linux
The issue stems that Mac OS X uses a case-insensitive filesystem by
default, while most Linux filesystems are case-sensitive. The classNames
package will require successfully on Mac OS X during Travis tests, but
since the spec test suite isn't normally run under Linux this bug is
more unlikely to appear.
2015-12-08 19:42:36 -05:00
Ben Gotow 5ca28a340d fix(auth): Track authentication success / failure rates by provider 2015-12-08 16:39:38 -08:00
Ben Gotow b53dac178d fix(serialization): Inflate / deflate JSON from database with registered object system 2015-12-08 15:14:43 -08:00
Ben Gotow d3fcc6cde6 Revert "fix(json): serialize blob data"
This reverts commit e275f353c1.
2015-12-08 15:14:35 -08:00
mbilker 7b037ae8f2 fix(tests): replace () with [] for properties of process.env
This bug appeared during a Travis test run, and only appeared on
the Linux hosts running the tests. The function appears to treat
the `process.env` as a set of functions, not properties. This
commit correctly interprets them as properties.
2015-12-08 18:06:41 -05:00
Evan Morikawa e275f353c1 fix(json): serialize blob data
Summary:
A fix to reserialize JSON blob data properly for complex object types.
We should investigate overriding all of JSON.parse and JSON.stringify.
This coming in a future diff.

Also we were using old Electron APIs that were throwing backend errors

Test Plan: todo

Reviewers: juan, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2326
2015-12-08 16:11:22 -05:00
Juan Tejada 17e9cc8921 fix(composer): Pass in onFocus handler correctly to contenteditable
- Fixes issue where body lost focus when typing and focus switched to to
field
- Now passes the onFocus handler as part of a `ContenteditableExtension`
2015-12-08 11:00:33 -08:00
Evan Morikawa 7d43622471 fix(composer): fix bold, italic, underline keybinding 2015-12-08 10:20:49 -05:00
Ben Gotow 0af5fea3dc fix(expand-all): Fixes for dark theme, don't show expand when one message 2015-12-07 18:01:06 -08:00
Ben Gotow b12d23a33d fix(templates): Example now depends on underscore 2015-12-07 17:33:51 -08:00
Ben Gotow 013d50a26b fix(templates): Unregister preferences tab when disabled 2015-12-07 17:23:59 -08:00
Ben Gotow 30c58e90a6 feat(observables): Implementation of observables to replace some stores
Summary:
Add concept of "final" to Query, clean up internals

Tiny bug fixes

RxJs Observables!

WIP

Test Plan: Run tests

Reviewers: evan, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D2319
2015-12-07 16:52:46 -08:00
Evan Morikawa 58c853ef76 fix(composer): detect system language for spellchecking 2015-12-07 19:33:18 -05:00
Juan Tejada c261488ba1 fix(specs): Update specs for EditableList 2015-12-07 15:59:24 -08:00
Juan Tejada 1ffd324dde fix(editable-list): Fix use of children props in EditableNode + updates
- Fix issue with using this.props.children which was preventing
rerendering
- Updates styles for list
- Updates create item input:
  - Add key to prevent warning
  - Add prop for the placeholder
  - Add onBlur behavior
2015-12-07 15:57:30 -08:00
Ben Gotow a1bb98ebf4 feat(paste): Paste accepts more HTML, paste and match style now available
Summary:
Related to #320, #494, #515, #553

Ignore newlines and returns in HTML, they can be inside tags

Allow all attributes so that paste from excel looks nice

Never let someone paste a `contenteditable` attribute

Update specs

Test Plan: Run new specs

Reviewers: juan, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2309
2015-12-07 15:34:03 -08:00
Ben Gotow d8c79a4d50 fix(theme): Dark mode styling for undo/redo component 2015-12-07 15:11:11 -08:00
Ben Gotow 2320292c15 fix(theme): Dark mode styling of the from field, "More contacts" button
Fixes #607
2015-12-07 15:05:44 -08:00
Ben Gotow fc2118aade fix(downloads): Improve inline attachment handling
- Show downloading state for inline attachments
- Ensure that the UI updates /after/ the download has completed
- Don't delete finished downloads (previously we were forgetting that a file was downloaded and checking again and again)

Fixes #462
2015-12-07 15:00:25 -08:00
Juan Tejada 31796e396d update(components): Add support to create new items inside EditableList
- Adds logic to allow simple item creation
- Adds new onItemCreated callback
- Updates specs
2015-12-07 12:40:39 -08:00
Ben Gotow 68a0a81f77 bump(version): 0.3.28 2015-12-07 12:08:51 -08:00
Juan Tejada f7b73c6920 fix(important): Fixes keymap handlers for mark as important/unimportant
- Updates to bind handlers inside thread list
- Fixes typo in event name
- Updates config path for showImportant
2015-12-07 12:05:40 -08:00
Ben Gotow 77394b837d fix(license): GPLv3 => GPL-3.0 2015-12-07 10:50:47 -08:00
Ben Gotow dd7cd370b7 Merge pull request #413 from mbilker/cleanup-download-delete-after-trigger
fix(FileDownloadStore): delete download from @_downloads after @trigger
2015-12-07 10:46:20 -08:00
Ben Gotow 46281dd0b0 Merge pull request #525 from Yerlix/master
Change backspace behavior
2015-12-07 10:40:43 -08:00
Ben Gotow 92b3e6777b fix(search): URI encode search queries to prevent 400s 2015-12-07 10:37:26 -08:00
Evan Morikawa 989f38ca77 feat(ci): add Travis and AppVeyor ci support 2015-12-07 12:48:26 -05:00
Juan Tejada 69a50365bc feat(components): Add EditableList component to component-kit
Summary:
- Generic list component wich supports adding, editing and removing
string-like items or components
- Needs some css love

Test Plan: - Unit tests.

Reviewers: evan, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2322
2015-12-07 08:15:40 -08:00